Home » Mailing list archives » linux-kernel » 2008 » April » 30

[patch, -git] drivers/media build fix for modular builds

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Molnar <mingo@...>
To: Mauro Carvalho Chehab <mchehab@...>
Cc: Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, <linux-dvb-maintainer@...>, <video4linux-list@...>, <linux-kernel@...>
Subject: [patch, -git] drivers/media build fix for modular builds
Date: Wednesday, April 30, 2008 - 3:48 am

fix allmodconfig build bug introduced in latest -git by commit 
7c91f0624a9 ("V4L/DVB(7767): Move tuners to common/tuners"):

  LD      kernel/built-in.o
  LD      drivers/built-in.o
  ld: drivers/media/built-in.o: No such file: No such file or directory

which happens if all media drivers are modular:

  http://redhat.com/~mingo/misc/config-Wed_Apr_30_09_24_48_CEST_2008.bad

In that case there's no obj-y rule connecting all the built-in.o files and
the link tree breaks.

the fix is to add a guaranteed obj-y rule for the core vmlinux to build.
(which results in an empty object file if all media drivers are modular)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/media/Makefile |    2 ++
 1 file changed, 2 insertions(+)

Index: linux/drivers/media/Makefile
===================================================================
--- linux.orig/drivers/media/Makefile
+++ linux/drivers/media/Makefile
@@ -2,6 +2,8 @@
 # Makefile for the kernel multimedia device drivers.
 #
 
+obj-y := common/
+
 obj-$(CONFIG_VIDEO_MEDIA) += common/
 
 # Since hybrid devices are here, should be compiled if DVB and/or V4L
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[GIT PATCHES] V4L/DVB updates and fixes for 2.6.26, Mauro Carvalho Chehab, (Tue Apr 29, 5:50 pm)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Patrick Boettcher, (Wed Apr 30, 4:02 am)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Mauro Carvalho Chehab, (Wed Apr 30, 3:03 pm)
[patch, -git] drivers/media build fix for modular builds, Ingo Molnar, (Wed Apr 30, 3:48 am)
Re: [patch, -git] drivers/media build fix for modular builds, David Miller, (Wed Apr 30, 3:52 am)
Re: [patch, -git] drivers/media build fix for modular builds, Ingo Molnar, (Wed Apr 30, 4:13 am)
Re: [patch, -git] drivers/media build fix for modular builds, Sam Ravnborg, (Wed Apr 30, 5:25 am)
Re: [patch, -git] drivers/media build fix for modular builds, Ingo Molnar, (Wed Apr 30, 5:37 am)
Re: [patch, -git] drivers/media build fix for modular builds, Sam Ravnborg, (Wed Apr 30, 5:55 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 4:27 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 4:42 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 4:56 am)
Re: [patch, -git] drivers/media build fix for modular builds, Sam Ravnborg, (Wed Apr 30, 5:26 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 5:40 am)
Re: [patch, -git] drivers/media build fix for modular builds, Ingo Molnar, (Wed Apr 30, 6:36 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 5:20 am)
Re: [patch, -git] drivers/media build fix for modular builds, Andrew Morton, (Wed Apr 30, 7:40 am)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., Trent Piepho, (Wed Apr 30, 5:52 pm)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., , (Wed Apr 30, 6:38 pm)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 9:03 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 11:25 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 11:48 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 12:12 pm)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 12:31 pm)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 5:35 pm)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., Michael Krufky, (Wed Apr 30, 10:39 am)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., Andrew Morton, (Wed Apr 30, 11:34 am)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., Mauro Carvalho Chehab, (Wed Apr 30, 11:48 am)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., Michael Krufky, (Wed Apr 30, 11:39 am)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., Mike Galbraith, (Wed Apr 30, 12:01 pm)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., Andrew Morton, (Wed Apr 30, 11:29 am)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., Mike Galbraith, (Wed Apr 30, 11:30 am)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Michael Krufky, (Tue Apr 29, 7:49 pm)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Mauro Carvalho Chehab, (Tue Apr 29, 8:00 pm)
Re: [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26, Linus Torvalds, (Tue Apr 29, 5:59 pm)