login
Header Space

 
 

Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Mauro Carvalho Chehab <mchehab@...>
Cc: Linus Torvalds <torvalds@...>, <linux-dvb-maintainer@...>, Andrew Morton <akpm@...>, <video4linux-list@...>, <linux-kernel@...>
Date: Tuesday, April 29, 2008 - 7:49 pm

On Tue, Apr 29, 2008 at 5:50 PM, Mauro Carvalho Chehab
<mchehab@infradead.org> wrote:

[snip]



Linus has already merged the changes (thank you, Linus) ... However,
there is a bug.

My "remove static dependencies on analog tuner sub-modules" patch was
applied after Mauro's "Rename common tuner Kconfig names to use the
same" patch.

My patch has conditional behavior, based on CONFIG_DVB_CORE_ATTACH,
which was renamed to CONFIG_MEDIA_ATTACH in Mauro's patch.

To fix this, we need to do:

sed -i s/"CONFIG_DVB_CORE_ATTACH"/"CONFIG_MEDIA_ATTACH"/1
drivers/media/video/tuner-core.c

The issue will cause invalid module use counts upon unloading analog
tuner modules, if CONFIG_MEDIA_ATTACH is enabled.

I would be happy to fix this myself, but Mauro's patch has not yet
been backported into the linuxtv.org repository.

Mauro, can you do the above fix and send it in to Linus?

Thanks,

Mike Krufky
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCHES] V4L/DVB updates and fixes for 2.6.26, Mauro Carvalho Chehab, (Tue Apr 29, 5:50 pm)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Patrick Boettcher, (Wed Apr 30, 4:02 am)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Mauro Carvalho Chehab, (Wed Apr 30, 3:03 pm)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 11:25 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 11:48 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 12:12 pm)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 12:31 pm)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 5:35 pm)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., Mauro Carvalho Chehab, (Wed Apr 30, 11:48 am)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Michael Krufky, (Tue Apr 29, 7:49 pm)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Mauro Carvalho Chehab, (Tue Apr 29, 8:00 pm)
Re: [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26, Linus Torvalds, (Tue Apr 29, 5:59 pm)
speck-geostationary