Home » Mailing list archives » linux-kernel » 2008 » April » 29

Re: [PATCH] bitops: remove "optimizations"

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Miller <davem@...>
To: <tglx@...>
Cc: <torvalds@...>, <harvey.harrison@...>, <mingo@...>, <akpm@...>, <linux-kernel@...>
Subject: Re: [PATCH] bitops: remove "optimizations"
Date: Tuesday, April 29, 2008 - 6:58 pm

From: Thomas Gleixner <tglx@linutronix.de>
Date: Tue, 29 Apr 2008 18:51:51 +0200 (CEST)


So I did a quick test, just #if 0'ing out the optimization inline
portions of the find_first_bit() code in linux/bitops.h, and forcing
it to always unconditionally call __find_first_bit() fixes the
regression.

Given that others who tested could not find one case where the
optimization cases actually applied, and it's breaking things for me,
my theory is that it's triggering for some obscure case on sparc64 and
thus showing a bug in these optimizations since in practice I'm the
only person to actually test this new code.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] bitops: simplify generic bit finding functions, Harvey Harrison, (Sun Apr 27, 4:19 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Alexander van Heukelum, (Mon Apr 28, 10:32 am)
Re: [PATCH] bitops: simplify generic bit finding functions, Linus Torvalds, (Sun Apr 27, 4:26 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Alexander van Heukelum, (Mon Apr 28, 10:58 am)
Re: [PATCH] bitops: simplify generic bit finding functions, Thomas Gleixner, (Mon Apr 28, 10:04 am)
Re: [PATCH] bitops: simplify generic bit finding functions, Linus Torvalds, (Mon Apr 28, 12:25 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Thomas Gleixner, (Mon Apr 28, 12:47 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Linus Torvalds, (Mon Apr 28, 12:54 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Andi Kleen, (Mon Apr 28, 3:57 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Thomas Gleixner, (Mon Apr 28, 3:26 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Linus Torvalds, (Mon Apr 28, 3:37 pm)
[PATCH] bitops: remove "optimizations", Thomas Gleixner, (Tue Apr 29, 6:01 am)
Re: [PATCH] bitops: remove "optimizations", David Miller, (Tue Apr 29, 6:03 am)
Re: [PATCH] bitops: remove "optimizations", David Miller, (Tue Apr 29, 8:34 am)
Re: [PATCH] bitops: remove "optimizations", Thomas Gleixner, (Tue Apr 29, 12:51 pm)
Re: [PATCH] bitops: remove "optimizations", David Miller, (Tue Apr 29, 6:58 pm)
Re: [PATCH] bitops: remove "optimizations", David Miller, (Tue Apr 29, 7:30 pm)
Re: [PATCH] bitops: remove "optimizations", Ingo Molnar, (Tue Apr 29, 10:20 am)
Re: [PATCH] bitops: remove "optimizations", David Miller, (Tue Apr 29, 6:31 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Ingo Molnar, (Mon Apr 28, 5:55 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Alexander van Heukelum, (Mon Apr 28, 11:10 am)
Re: [PATCH] bitops: simplify generic bit finding functions, Thomas Gleixner, (Mon Apr 28, 11:58 am)
Re: [PATCH] bitops: simplify generic bit finding functions, Harvey Harrison, (Sun Apr 27, 4:29 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Linus Torvalds, (Sun Apr 27, 4:38 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Al Viro, (Sun Apr 27, 5:02 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Al Viro, (Sun Apr 27, 4:36 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Harvey Harrison, (Sun Apr 27, 4:38 pm)