[PATCH] pata_atiixp fix PIO timing misprogramming

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-ide@...>
Cc: LKML <linux-kernel@...>
Date: Tuesday, April 29, 2008 - 5:49 pm

commit d7b5a23fc6e85456ed00a997ff2d925fb3f0dc52
Author: Jeff Garzik <jeff@garzik.org>
Date:   Tue Apr 29 17:39:45 2008 -0400

    [libata] pata_atiixp: fix PIO timing data misprogramming
    
    Use correct variable, achieve desired result...
    
    Spotted by LKML/linux-ide poster whose name I lost (apologies!)
    
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

 drivers/ata/pata_atiixp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

d7b5a23fc6e85456ed00a997ff2d925fb3f0dc52
diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c
index 78738fb..d7de7ba 100644
--- a/drivers/ata/pata_atiixp.c
+++ b/drivers/ata/pata_atiixp.c
@@ -88,8 +88,8 @@ static void atiixp_set_pio_timing(struct ata_port *ap, struct ata_device *adev,
 	pci_write_config_word(pdev, ATIIXP_IDE_PIO_MODE, pio_mode_data);
 
 	pci_read_config_word(pdev, ATIIXP_IDE_PIO_TIMING, &pio_timing_data);
-	pio_mode_data &= ~(0xFF << timing_shift);
-	pio_mode_data |= (pio_timings[pio] << timing_shift);
+	pio_timing_data &= ~(0xFF << timing_shift);
+	pio_timing_data |= (pio_timings[pio] << timing_shift);
 	pci_write_config_word(pdev, ATIIXP_IDE_PIO_TIMING, pio_timing_data);
 }
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] pata_atiixp fix PIO timing misprogramming, Jeff Garzik, (Tue Apr 29, 5:49 pm)