Home » Mailing list archives » linux-kernel » 2008 » April » 29

[PATCH] Optimize lock in queue unplugging

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Mikulas Patocka <mpatocka@...>
To: Jens Axboe <jens.axboe@...>
Cc: <linux-kernel@...>, Mike Anderson <andmike@...>, Alasdair Graeme Kergon <agk@...>
Subject: [PATCH] Optimize lock in queue unplugging
Date: Tuesday, April 29, 2008 - 3:12 pm

Hi

Mike Anderson was doing an OLTP benchmark on a computer with 48 physical 
disks mapped to one logical device via device mapper.

He found that there was a slowdown on request_queue->lock in function 
generic_unplug_device. The slowdown is caused by the fact that when some 
code calls unplug on the device mapper, device mapper calls unplug on all 
physical disks. These unplug calls take the lock, find that the queue is 
already unplugged, release the lock and exit.

With the below patch, performance of the benchmark was increased by 18% 
(the whole OLTP application, not just block layer microbenchmarks).

So I'm submitting this patch for upstream. I think the patch is correct, 
because when more threads call simultaneously plug and unplug, it is 
unspecified, if the queue is or isn't plugged (so the patch can't make 
this worse). And the caller that plugged the queue should unplug it 
anyway. (if it doesn't, there's 3ms timeout).

Mikulas


Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

---
  block/blk-core.c |    3 +++
  1 file changed, 3 insertions(+)

Index: linux-2.6.25/block/blk-core.c
===================================================================
--- linux-2.6.25.orig/block/blk-core.c	2008-04-17 04:49:44.000000000 +0200
+++ linux-2.6.25/block/blk-core.c	2008-04-29 18:50:37.000000000 +0200
@@ -271,6 +271,9 @@ EXPORT_SYMBOL(__generic_unplug_device);
   **/
  void generic_unplug_device(struct request_queue *q)
  {
+	if (likely(!blk_queue_plugged(q)))
+		return;
+
  	spin_lock_irq(q->queue_lock);
  	__generic_unplug_device(q);
  	spin_unlock_irq(q->queue_lock);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Optimize lock in queue unplugging, Mikulas Patocka, (Tue Apr 29, 3:12 pm)
Re: [PATCH] Optimize lock in queue unplugging, Jens Axboe, (Tue Apr 29, 3:25 pm)
Re: [PATCH] Optimize lock in queue unplugging, Mike Anderson, (Tue Apr 29, 4:29 pm)
Re: [PATCH] Optimize lock in queue unplugging, Jens Axboe, (Wed Apr 30, 3:14 am)
Re: [PATCH] Optimize lock in queue unplugging, Mikulas Patocka, (Wed Apr 30, 9:54 am)
Re: [PATCH] Optimize lock in queue unplugging, Jens Axboe, (Sun May 4, 3:11 pm)
Re: [PATCH] Optimize lock in queue unplugging, Mikulas Patocka, (Mon May 5, 12:01 am)
Re: [PATCH] Optimize lock in queue unplugging, Jens Axboe, (Wed May 7, 3:45 am)
Re: [PATCH] Optimize lock in queue unplugging, Alasdair G Kergon, (Wed Apr 30, 6:38 am)
Re: [PATCH] Optimize lock in queue unplugging, Mikulas Patocka, (Tue Apr 29, 4:02 pm)
Re: [PATCH] Optimize lock in queue unplugging, Jens Axboe, (Tue Apr 29, 4:05 pm)