Home » Mailing list archives » linux-kernel » 2008 » April » 29

Re: [27/37] tehuti: move ioctl perm check closer to function start (CVE-2008-1675)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Greg KH <gregkh@...>
Cc: Alan Cox <alan@...>, <linux-kernel@...>, <stable@...>, Justin Forbes <jmforbes@...>, Zwane Mwaikambo <zwane@...>, Theodore Ts'o <tytso@...>, Randy Dunlap <rdunlap@...>, Dave Jones <davej@...>, Chuck Wolber <chuckw@...>, Chris Wedgwood <reviews@...>, Michael Krufky <mkrufky@...>, Chuck Ebbert <cebbert@...>, Domenico Andreoli <cavokz@...>, <akpm@...>, Jeff Garzik <jgarzik@...>
Subject: Re: [27/37] tehuti: move ioctl perm check closer to function start (CVE-2008-1675)
Date: Tuesday, April 29, 2008 - 3:02 pm

On Tue, 29 Apr 2008, Greg KH wrote:

Done. It will be commit 6203554207728f43cfb9fd48585cd6500da73d42 when I 
push out (but please point to the original commit that actually adds the 
check: 6203554 just changes from CAP_NET_ADMIN to CAP_SYS_RAWIO and is not 
as important as adding the check in the first place.

(I don't know of anybody who actually really uses capabilities with 
individual bits, so I seriously doubt it matters)

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[00/37] 2.6.25-stable review, Greg KH, (Tue Apr 29, 1:17 pm)
Re: [00/37] 2.6.25-stable review, Andre Noll, (Wed Apr 30, 3:58 am)
Re: [stable] [00/37] 2.6.25-stable review, Chris Wright, (Wed Apr 30, 8:25 pm)
[37/37] hrtimer: raise softirq unlocked to avoid circular lo..., Greg KH, (Tue Apr 29, 1:19 pm)
[36/37] x86: Fix 32-bit x86 MSI-X allocation leakage, Greg KH, (Tue Apr 29, 1:19 pm)
[35/37] alpha: unbreak OSF/1 (a.out) binaries, Greg KH, (Tue Apr 29, 1:19 pm)
[34/37] SCSI: qla2xxx: Correct regression in relogin code., Greg KH, (Tue Apr 29, 1:19 pm)
[33/37] RDMA/nes: Fix adapter reset after PXE boot, Greg KH, (Tue Apr 29, 1:19 pm)
[32/37] hrtimer: timeout too long when using HRTIMER_CB_SOFT..., Greg KH, (Tue Apr 29, 1:19 pm)
[31/37] mm: fix possible off-by-one in walk_pte_range(), Greg KH, (Tue Apr 29, 1:19 pm)
[30/37] dz: test after postfix decrement fails in dz_console..., Greg KH, (Tue Apr 29, 1:19 pm)
[29/37] rtc-pcf8583 build fix, Greg KH, (Tue Apr 29, 1:19 pm)
[28/37] aio: io_getevents() should return if io_destroy() is..., Greg KH, (Tue Apr 29, 1:19 pm)
[27/37] tehuti: move ioctl perm check closer to function sta..., Greg KH, (Tue Apr 29, 1:19 pm)
Re: [27/37] tehuti: move ioctl perm check closer to function..., Alan Cox, (Tue Apr 29, 2:13 pm)
Re: [27/37] tehuti: move ioctl perm check closer to function..., Greg KH, (Tue Apr 29, 2:55 pm)
Re: [27/37] tehuti: move ioctl perm check closer to function..., Linus Torvalds, (Tue Apr 29, 3:02 pm)
Re: [stable] [27/37] tehuti: move ioctl perm check closer to..., Greg KH, (Wed Apr 30, 12:39 pm)
[26/37] tehuti: check register size (CVE-2008-1675), Greg KH, (Tue Apr 29, 1:18 pm)
[25/37] b43: Workaround DMA quirks, Greg KH, (Tue Apr 29, 1:18 pm)
[24/37] b43: Add more btcoexist workarounds, Greg KH, (Tue Apr 29, 1:18 pm)
[23/37] b43: Workaround invalid bluetooth settings, Greg KH, (Tue Apr 29, 1:18 pm)
[22/37] ssb: Fix all-ones boardflags, Greg KH, (Tue Apr 29, 1:18 pm)
[21/37] x86, pci: fix off-by-one errors in some pirq warnings, Greg KH, (Tue Apr 29, 1:18 pm)
[20/37] SELinux: no BUG_ON(!ss_initialized) in selinux_clone..., Greg KH, (Tue Apr 29, 1:18 pm)
[18/37] S2io: Fix memory leak during free_tx_buffers, Greg KH, (Tue Apr 29, 1:18 pm)
[19/37] S2io: Version update for memory leak fix during free..., Greg KH, (Tue Apr 29, 1:18 pm)
[17/37] V4L: cx88: enable radio GPIO correctly, Greg KH, (Tue Apr 29, 1:18 pm)
[16/37] V4L: tea5761: bugzilla #10462: tea5761 autodetection..., Greg KH, (Tue Apr 29, 1:18 pm)
[15/37] V4L: Fix VIDIOCGAP corruption in ivtv, Greg KH, (Tue Apr 29, 1:18 pm)
[14/37] RDMA/nes: Free IRQ before killing tasklet, Greg KH, (Tue Apr 29, 1:18 pm)
[13/37] cgroup: fix a race condition in manipulating tsk-&gt..., Greg KH, (Tue Apr 29, 1:18 pm)
[12/37] dm snapshot: fix chunksize sector conversion, Greg KH, (Tue Apr 29, 1:18 pm)
[11/37] USB: OHCI: fix bug in controller resume, Greg KH, (Tue Apr 29, 1:18 pm)
[10/37] IPSEC: Fix catch-22 with algorithm IDs above 31, Greg KH, (Tue Apr 29, 1:18 pm)
[09/37] net: Fix wrong interpretation of some copy_to_user()..., Greg KH, (Tue Apr 29, 1:18 pm)
[08/37] rose: Socket lock was not released before returning ..., Greg KH, (Tue Apr 29, 1:18 pm)
[07/37] RTNETLINK: Fix bogus ASSERT_RTNL warning, Greg KH, (Tue Apr 29, 1:18 pm)
[05/37] tcp: tcp_probe buffer overflow and incorrect return ..., Greg KH, (Tue Apr 29, 1:18 pm)
[04/37] tg3: 5701 DMA corruption fix, Greg KH, (Tue Apr 29, 1:18 pm)
[03/37] JFFS2: Fix free space leak with in-band cleanmarkers, Greg KH, (Tue Apr 29, 1:17 pm)
[02/37] USB: Add HP hs2300 Broadband Wireless Module to sier..., Greg KH, (Tue Apr 29, 1:17 pm)
[01/37] USB: log an error message when USB enumeration fails, Greg KH, (Tue Apr 29, 1:17 pm)