Re: Solid freezes with 2.6.25

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Bernhard Walle
Date: Tuesday, April 29, 2008 - 8:54 am

Hi,

* Andrew Morton [2008-04-28 09:25]:

Hm ..., can you mail /proc/interrupts of the affected system? According
to the HPET specification 
 

  General Interrupt Status Register Field Definitions
  --------------------------------------------------------

  T2_INT_STS  Timer 2 Interrupt Active: Same functionality as Timer 0.
  T1_INT_STS  Timer 1 Interrupt Active: Same functionality as Timer 0.
  T0_INT_STS  Timer 0 Interrupt Active:
  
               The functionality of this bit depends on whether the edge
               or level-triggered mode is used for this timer:

               If set to level-triggered mode:
                       This bit defaults to 0. This bit will be set by
                       hardware if the corresponding timer interrupt is
                       active. Once the bit is set, it can be cleared by
                       software writing a 1 to the same bit position.
                       Writes of 0 to this bit will have no effect. For
                       example, if the bit is already set a write of 0
                       will not clear the bit.

               If set to edge-triggered mode:
                       This bit should be ignored by software. Software
                       should always write 0 to this bit.

  --------------------------------------------------------

On all systems I checked the interrupt is edge-triggered. So, if your
interrupt is level triggered, that might be the cause.


Well, can you disable CONFIG_HPET_EMULATE_RTC entirely and try again?


Can you try that patch and see if the IRQ handler is really called
repeatedly in that case?


        Bernhard


--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -679,6 +679,9 @@ irqreturn_t hpet_rtc_interrupt(int irq,
 {
        struct rtc_time curr_time;
        unsigned long rtc_int_flag = 0;
+       struct hpet __iomem *hpet = hpet_virt_address;
+
+       printk(KERN_INFO "status=%d\n", readl(&hpet->hpet_isr));
 
        hpet_rtc_timer_reinit();
        memset(&curr_time, 0, sizeof(struct rtc_time));
--- a/include/asm-x86/hpet.h
+++ b/include/asm-x86/hpet.h
@@ -35,6 +35,10 @@
 #define        HPET_LEGACY_8254        2
 #define        HPET_LEGACY_RTC         8
 
+#define HPET_T0_INT_STS                (1<<0)
+#define HPET_T1_INT_STS                (1<<1)
+#define HPET_T2_INT_STS                (1<<2)
+
 #define HPET_TN_LEVEL          0x0002
 #define HPET_TN_ENABLE         0x0004
 #define HPET_TN_PERIODIC       0x0008

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Solid freezes with 2.6.25, Gabor Gombas, (Mon Apr 28, 7:29 am)
Re: Solid freezes with 2.6.25, Oliver Pinter, (Mon Apr 28, 7:54 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Mon Apr 28, 7:59 am)
Re: Solid freezes with 2.6.25, Andrew Morton, (Mon Apr 28, 9:25 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Tue Apr 29, 12:24 am)
Re: Solid freezes with 2.6.25, Andrew Morton, (Tue Apr 29, 12:37 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Tue Apr 29, 2:43 am)
Re: Solid freezes with 2.6.25, Bernhard Walle, (Tue Apr 29, 2:50 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Tue Apr 29, 2:53 am)
Re: Solid freezes with 2.6.25, Bernhard Walle, (Tue Apr 29, 8:54 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Wed Apr 30, 6:38 am)
Re: Solid freezes with 2.6.25, Bernhard Walle, (Wed Apr 30, 7:51 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Wed May 7, 4:43 am)
Re: Solid freezes with 2.6.25, Bernhard Walle, (Wed May 7, 5:45 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Wed May 7, 6:42 am)
Re: Solid freezes with 2.6.25, Bernhard Walle, (Mon May 12, 5:21 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Tue May 13, 7:39 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Sun Jun 15, 10:11 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Fri Jul 25, 1:52 am)
Re: Solid freezes with 2.6.25, Bernhard Walle, (Fri Jul 25, 2:04 am)
Re: Solid freezes with 2.6.25, Gabor Gombas, (Mon Aug 25, 5:27 am)