RE: [PATCH 7/12] cciss: assign PDE->data before gluing PDE into /proc tree

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Miller, Mike (OS Dev) <Mike.Miller@...>

To: Denis V. Lunev <den@...>, akpm@linux-foundation.org <akpm@...>

Cc: linux-kernel@vger.kernel.org <linux-kernel@...>, Alexey Dobriyan <adobriyan@...>, Eric W. Biederman <ebiederm@...>, ISS StorageDev <iss_storagedev@...>, Greg Kroah-Hartman <gregkh@...>

Subject: RE: [PATCH 7/12] cciss: assign PDE->data before gluing PDE into /proc tree

Date: Tuesday, April 29, 2008 - 11:26 am

> -----Original Message-----
quoted text> From: den@sw.ru [mailto:den@sw.ru] On Behalf Of Denis V. Lunev
> Sent: Tuesday, April 29, 2008 6:13 AM
> To: akpm@linux-foundation.org
> Cc: linux-kernel@vger.kernel.org; Denis V. Lunev; Alexey
> Dobriyan; Eric W. Biederman; ISS StorageDev; Greg Kroah-Hartman
> Subject: [PATCH 7/12] cciss: assign PDE->data before gluing
> PDE into /proc tree
>
> Simply replace proc_create and further data assigned with
> proc_create_data.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Cc: Alexey Dobriyan <adobriyan@openvz.org>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Cc: <iss_storagedev@hp.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>

Acked-by: Mike Miller <mike.miller@hp.com>

quoted text> ---
>  drivers/block/cciss.c |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index e539be5..e336b05 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -428,13 +428,9 @@ static void __devinit cciss_procinit(int i)
>                 proc_cciss = proc_mkdir("driver/cciss", NULL);
>         if (!proc_cciss)
>                 return;
> -       pde = proc_create(hba[i]->devname, S_IWUSR | S_IRUSR
> | S_IRGRP |
> +       pde = proc_create_data(hba[i]->devname, S_IWUSR | S_IRUSR |
> + S_IRGRP |
>                                         S_IROTH, proc_cciss,
> -                                       &cciss_proc_fops);
> -       if (!pde)
> -               return;
> -
> -       pde->data = hba[i];
> +                                       &cciss_proc_fops, hba[i]);
>  }
>  #endif                         /* CONFIG_PROC_FS */
>
> --
> 1.5.3.rc5
>
>
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/12] Further PDE->data assignments cleanups, Denis V. Lunev, (Tue Apr 29, 7:12 am)

[PATCH 8/12] powerpc: assign PDE->data before gluing PDE ..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

[PATCH 7/12] cciss: assign PDE->data before gluing PDE in..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

RE: [PATCH 7/12] cciss: assign PDE->data before gluing PD..., Miller, Mike (OS Dev), (Tue Apr 29, 11:26 am)

[PATCH 9/12] ipv4: assign PDE->data before gluing PDE int..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE..., Stoyan Gaydarov, (Fri Jul 11, 11:12 pm)

Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE..., Denis V. Lunev, (Sat Jul 12, 10:55 am)

Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE..., Eric W. Biederman, (Fri Jul 11, 11:42 pm)

Re: [PATCH 9/12] ipv4: assign PDE->data before gluing PDE..., David Miller, (Fri May 2, 7:10 am)

[PATCH 3/12] net: assign PDE->data before gluing PDE into..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 3/12] net: assign PDE->data before gluing PDE ..., David Miller, (Fri May 2, 5:46 am)

[PATCH 5/12] atm: assign PDE->data before gluing PDE into..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 5/12] atm: assign PDE->data before gluing PDE ..., David Miller, (Fri May 2, 7:08 am)

[PATCH 4/12] ipv6: assign PDE->data before gluing PDE int..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 4/12] ipv6: assign PDE->data before gluing PDE..., David Miller, (Fri May 2, 5:47 am)

[PATCH 11/12] netfilter: assign PDE->data before gluing P..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 11/12] netfilter: assign PDE->data before glui..., David Miller, (Fri May 2, 7:12 am)

Re: [PATCH 11/12] netfilter: assign PDE->data before glui..., Patrick McHardy, (Tue Apr 29, 8:01 am)

[PATCH 10/12] netfilter: assign PDE->fops before gluing P..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 10/12] netfilter: assign PDE->fops before glui..., David Miller, (Fri May 2, 7:11 am)

[PATCH 6/12] vlan: assign PDE->data before gluing PDE int..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 6/12] vlan: assign PDE->data before gluing PDE..., David Miller, (Fri May 2, 7:09 am)

[PATCH 2/12] netfilter: assign PDE->data before gluing PD..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 2/12] netfilter: assign PDE->data before gluin..., David Miller, (Fri May 2, 5:45 am)

[PATCH 12/12] netns: assign PDE->data before gluing entry..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 12/12] netns: assign PDE->data before gluing e..., David Miller, (Fri May 2, 7:12 am)

[PATCH 1/12] sunrpc: assign PDE->data before gluing PDE i..., Denis V. Lunev, (Tue Apr 29, 7:13 am)

Re: [PATCH 1/12] sunrpc: assign PDE->data before gluing P..., David Miller, (Fri May 2, 5:44 am)


linux-kernel:
Rafael J. Wysocki	[Bug #10493] mips BCM47XX compile error
Ingo Molnar	[patch 02/13] syslets: add syslet.h include file, user API/ABI definitions
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Andrea Arcangeli	[PATCH 00 of 11] mmu notifier #v16
git:

linux-netdev:
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Linus Torvalds	Re: [GIT]: Networking
Mark Lord	Re: [BUG] New Kernel Bugs
openbsd-misc:

RE: [PATCH 7/12] cciss: assign PDE->data before gluing PDE into /proc tree

Online users