Home » Mailing list archives » linux-kernel » 2008 » April » 29

Re: [PATCH 3/8] lockdep: fix fib_hash softirq inversion

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Peter Zijlstra <a.p.zijlstra@...>
To: <ego@...>
Cc: <linux-kernel@...>, Zdenek Kabelac <zdenek.kabelac@...>, Oleg Nesterov <oleg@...>, Heiko Carstens <heiko.carstens@...>, Rafael J. Wysocki <rjw@...>, Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>, Srivatsa Vaddagiri <vatsa@...>, Eric Dumazet <dada1@...>, David S. Miller <davem@...>
Subject: Re: [PATCH 3/8] lockdep: fix fib_hash softirq inversion
Date: Tuesday, April 29, 2008 - 10:45 am

On Tue, 2008-04-29 at 18:30 +0530, Gautham R Shenoy wrote:

This is a false positive, and hence we should not apply this patch.

I think I understand the problem and have an idea on how to fix lockdep,
but I haven't gotten around to actually doing so.

Esp in the light that fixing lockdep isn't a requirement (just a nice to
have) for these other cpu hotplug patches we should drop these patches.

So that is, 1-4 should not be applied to mainline. I'll work on a new
and improved 2 that'll make 3 and 4 unneeded.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/8] CPU-Hotplug: Fix CPU-Hotplug &lt;--&gt; cpufreq ..., Gautham R Shenoy, (Tue Apr 29, 8:56 am)
[PATCH 8/8] cpufreq: Nest down_write/read(cpufreq_rwsem) wit..., Gautham R Shenoy, (Tue Apr 29, 9:05 am)
[PATCH 7/8] cpu_hotplug: Introduce try_get_online_cpus(), Gautham R Shenoy, (Tue Apr 29, 9:03 am)
[PATCH 6/8] lockdep: annotate cpu_hotplug, Gautham R Shenoy, (Tue Apr 29, 9:02 am)
[PATCH 5/8] cpu: cpu-hotplug deadlock, Gautham R Shenoy, (Tue Apr 29, 9:02 am)
Re: [PATCH 5/8] cpu: cpu-hotplug deadlock, Oleg Nesterov, (Tue Apr 29, 10:33 am)
Re: [PATCH 5/8] cpu: cpu-hotplug deadlock, Gautham R Shenoy, (Wed Apr 30, 1:37 am)
Re: [PATCH 5/8] cpu: cpu-hotplug deadlock, Oleg Nesterov, (Wed Apr 30, 7:43 am)
Re: [PATCH 5/8] cpu: cpu-hotplug deadlock, Peter Zijlstra, (Tue Apr 29, 11:09 am)
Re: [PATCH 5/8] cpu: cpu-hotplug deadlock, Oleg Nesterov, (Tue Apr 29, 12:45 pm)
Re: [PATCH 5/8] cpu: cpu-hotplug deadlock, Peter Zijlstra, (Tue Apr 29, 1:31 pm)
[PATCH 4/8] net: af_netlink: deadlock, Gautham R Shenoy, (Tue Apr 29, 9:01 am)
Re: Hans Reiser, reiserfs developer, linux-os (Dick Johnson), (Tue Apr 29, 9:19 am)
[PATCH 3/8] lockdep: fix fib_hash softirq inversion, Gautham R Shenoy, (Tue Apr 29, 9:00 am)
Re: [PATCH 3/8] lockdep: fix fib_hash softirq inversion, Peter Zijlstra, (Tue Apr 29, 10:45 am)
[PATCH 2/8] lockdep: reader-in-writer recursion, Gautham R Shenoy, (Tue Apr 29, 8:58 am)
[PATCH 1/8] lockdep: fix recursive read lock validation, Gautham R Shenoy, (Tue Apr 29, 8:57 am)
Re: [PATCH 1/8] lockdep: fix recursive read lock validation, Bart Van Assche, (Tue Apr 29, 9:16 am)
Re: [PATCH 1/8] lockdep: fix recursive read lock validation, Peter Zijlstra, (Tue Apr 29, 10:57 am)
Re: [PATCH 1/8] lockdep: fix recursive read lock validation, Bart Van Assche, (Tue Apr 29, 11:03 am)
Re: [PATCH 1/8] lockdep: fix recursive read lock validation, Peter Zijlstra, (Tue Apr 29, 11:15 am)
Re: [PATCH 1/8] lockdep: fix recursive read lock validation, Bart Van Assche, (Tue Apr 29, 12:03 pm)
Re: [PATCH 1/8] lockdep: fix recursive read lock validation, Peter Zijlstra, (Tue Apr 29, 12:15 pm)
Re: [PATCH 1/8] lockdep: fix recursive read lock validation, Bart Van Assche, (Tue Apr 29, 12:29 pm)
Re: [PATCH 1/8] lockdep: fix recursive read lock validation, Peter Zijlstra, (Tue Apr 29, 1:04 pm)
Re: [PATCH 1/8] lockdep: fix recursive read lock validation, Bart Van Assche, (Tue Apr 29, 1:45 pm)
Re: [PATCH 1/8] lockdep: fix recursive read lock validation, Peter Zijlstra, (Tue Apr 29, 1:58 pm)