Home » Mailing list archives » linux-kernel » 2008 » April » 29

rtc: how should I handle an invalid state?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Uwe <Uwe.Kleine-Koenig@...>
To: Alessandro Zummo <a.zummo@...>, David Brownell <dbrownell@...>
Cc: <linux-kernel@...>
Subject: rtc: how should I handle an invalid state?
Date: Tuesday, April 29, 2008 - 8:19 am

Hello,

I'm still stuck with my rtc.  My current problem is setting the rtc
using hwclock --systohc.

The problem is that hwclock tries to read the current time before
setting the new one.  And if that fails, it doesn't update the rtc.

If no error occurs the procedure to read the time is:

	fd = open("/dev/rtc", O_RDONLY|O_LARGEFILE)
	ioctl(fd, RTC_UIE_ON, 0);
	select(fd + 1, [fd], NULL, NULL, {5, 0});
	ioctl(fd, RTC_RD_TIME, &rtc_time);

If one of ioctl(fd, RTC_UIE_ON, 0) or select(fd + 1, [fd], NULL, NULL,
{5, 0}) fail, hwclock aborts.

OTOH I don't want to report success in both because then there is no way
to distinguish between a valid and an unvalid date for hwclock.

Looking at some other drivers they don't seem to handle that case.

Maybe returning an invalid date could work?

What do you think?

Best regards
Uwe

-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
rtc: how should I handle an invalid state?, Uwe , (Tue Apr 29, 8:19 am)
Re: rtc: how should I handle an invalid state?, David Brownell, (Tue Apr 29, 3:12 pm)
Re: rtc: how should I handle an invalid state?, Uwe , (Wed Apr 30, 2:54 am)
Re: rtc: how should I handle an invalid state?, Alessandro Zummo, (Tue Apr 29, 8:51 am)