Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discrete layout v7

Score:

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Yinghai Lu <yhlu.kernel@...>

Cc: Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>, H. Peter Anvin <hpa@...>, Thomas Gleixner <tglx@...>, Mika Fischer <mika.fischer@...>, linux-kernel@vger.kernel.org <linux-kernel@...>

Subject: Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discrete layout v7

Date: Tuesday, April 29, 2008 - 7:51 am

Yinghai Lu wrote:
quoted text> On Tue, Apr 29, 2008 at 3:30 AM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>> On Tue, Apr 29, 2008 at 2:47 AM, Gabriel C <nix.or.die@googlemail.com> wrote:
>>  > Yinghai Lu wrote:
>>  >  > some BIOS like to use continus MTRR layout, and may X driver can not add
>>  >  > WB entries for graphical cards when 4g or more RAM installed.
>>  >  >
>>  >  > the patch will change MTRR to discrete.
>>  >  >
>>  >  > mtrr_chunk_size= could be used to have smaller continuous block to hold holes.
>>  >  > default is 256m, could be set according to size of graphics card memory.
>>  >  >
>>  >  > v2: fix -1 for UC checking
>>  >  > v3: default to disable, and need use enable_mtrr_cleanup to enable this feature
>>  >  >     skip the var state change warning.
>>  >  >     remove next_basek in range_to_mtrr()
>>  >  > v4: correct warning mask.
>>  >  > v5: CONFIG_MTRR_SANITIZER
>>  >  > v6: fix 1g, 2g, 512 aligment with extra hole
>>  >  > v7: gran_sizek to prevent running out of MTRRs.
>>  >  >
>>  >
>>  >  With this version ( and patch http://lkml.org/lkml/2008/4/29/97 ) applyed on latest linus git tree
>>  >  the box OOPS'es early.
>>  >
>>  >  Sorry I don't have time right now to write down the part of the OOPS I can see on monitor , I can try to find
>>  >  some time later.
>>  >
>>  >  In any way OOPS'es on __free_one_page+0x191/0x21e
>>
>>  thanks. found one problem with hole_basek ...
>>
>>  will send you v8, and hope it will be last version.
> 
> please try v8, it should get rid of the 8m entry. it need patch
> http://lkml.org/lkml/2008/4/29/97 too.

Box does boot with v8 but now I get that warning you fixed in v2 again =):

....
[    0.000000] Linux version 2.6.25-06058-ga01e035-dirty (crazy@thor) (gcc version 4.3.0 (Frugalware Linux) ) #805 SMP PREEMPT Tue Apr 29 13:04:49 CEST 2008
[    0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317
[    0.000000] BIOS-provided physical RAM map:
[    0.000000]  BIOS-e820: 0000000000000000 - 000000000009cc00 (usable)
[    0.000000]  BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved)
[    0.000000]  BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved)
[    0.000000]  BIOS-e820: 0000000000100000 - 00000000cf550000 (usable)
[    0.000000]  BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data)
[    0.000000]  BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
[    0.000000]  BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved)
[    0.000000]  BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved)
[    0.000000]  BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved)
[    0.000000]  BIOS-e820: 0000000100000000 - 000000012c000000 (usable)
[    0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used
[    0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used
[    0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used
[    0.000000] max_pfn_mapped = 1228800
[    0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
[    0.000000] After WB checking
[    0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000
[    0.000000] After UC checking
[    0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
[    0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
[    0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
[    0.000000] After sorting
[    0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600
[    0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000
[    0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
[    0.000000] range0: 0000000000000000 - 00000000c0000000
[    0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB
[    0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB
[    0.000000] range: 00000000c0000000 - 00000000d0000000
[    0.000000] Setting variable MTRR 2, base: 3072MB, range: 256MB, type WB
[    0.000000] hole: 00000000cc000000 - 00000000d0000000
[    0.000000] Setting variable MTRR 3, base: 3264MB, range: 64MB, type UC
[    0.000000] rangeX: 00000000d0000000 - 00000000d0000000
[    0.000000] range0: 0000000100000000 - 0000000120000000
[    0.000000] Setting variable MTRR 4, base: 4096MB, range: 512MB, type WB
[    0.000000] range: 0000000120000000 - 0000000130000000
[    0.000000] Setting variable MTRR 5, base: 4608MB, range: 256MB, type WB
[    0.000000] hole: 000000012c000000 - 0000000130000000
[    0.000000] Setting variable MTRR 6, base: 4800MB, range: 64MB, type UC
[    0.000000] DONE variable MTRRs
[    0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106
[    0.000000] After WB checking
[    0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000d0000
[    0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000130000
[    0.000000] After UC checking
[    0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000
[    0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
[    0.000000] After sorting
[    0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000
[    0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000
[    0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM.
[    0.000000] ------------[ cut here ]------------
[    0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1227 mtrr_trim_uncached_memory+0x30c/0x35a()
[    0.000000] Modules linked in:
[    0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06058-ga01e035-dirty #805
[    0.000000]
[    0.000000] Call Trace:
[    0.000000]  [<ffffffff8022d661>] warn_on_slowpath+0x51/0x78
[    0.000000]  [<ffffffff8067f0dc>] x86_get_mtrr_mem_range+0x241/0x25c
[    0.000000]  [<ffffffff8067d93e>] update_memory_range+0x95/0xb7
[    0.000000]  [<ffffffff8067fb02>] mtrr_trim_uncached_memory+0x30c/0x35a
[    0.000000]  [<ffffffff8067ca43>] setup_arch+0x280/0x4a2
[    0.000000]  [<ffffffff80676aa6>] start_kernel+0x6e/0x308
[    0.000000]  [<ffffffff80676432>] x86_64_start_kernel+0x241/0x24a
[    0.000000]
[    0.000000] ---[ end trace ca143223eefdc828 ]---
[    0.000000] update e820 for mtrr -- holes
[    0.000000] modified physical RAM map:
[    0.000000]  modified: 0000000000000000 - 000000000009cc00 (usable)
[    0.000000]  modified: 000000000009cc00 - 00000000000a0000 (reserved)
[    0.000000]  modified: 00000000000e4000 - 0000000000100000 (reserved)
[    0.000000]  modified: 0000000000100000 - 00000000cc000000 (usable)
[    0.000000]  modified: 00000000cc000000 - 00000000cf550000 (reserved)
[    0.000000]  modified: 00000000cf550000 - 00000000cf55e000 (ACPI data)
[    0.000000]  modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS)
[    0.000000]  modified: 00000000cf5e0000 - 00000000cf600000 (reserved)
[    0.000000]  modified: 00000000fee00000 - 00000000fee01000 (reserved)
[    0.000000]  modified: 00000000ffc00000 - 000000012c000000 (reserved)
[    0.000000] Entering add_active_range(0, 0, 156) 3 entries of 256 used
[    0.000000] Entering add_active_range(0, 256, 835584) 3 entries of 256 used
[    0.000000] max_pfn_mapped = 1228800
[    0.000000] init_memory_mapping 

...
                                                                                                                       > 
quoted text> Thanks
> 
> Yinghai Lu
> 


Gabriel
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] x86: mtrr cleanup for converting continuous to discr..., Yinghai Lu, (Mon Apr 28, 2:37 am)

[PATCH] x86: mtrr cleanup for converting continuous to discr..., Yinghai Lu, (Mon Apr 28, 5:06 am)

[PATCH] x86: mtrr cleanup for converting continuous to discr..., Yinghai Lu, (Mon Apr 28, 3:44 pm)

[PATCH] x86: mtrr cleanup for converting continuous to discr..., Yinghai Lu, (Mon Apr 28, 4:16 pm)

[PATCH] x86: mtrr cleanup for converting continuous to discr..., Yinghai Lu, (Mon Apr 28, 6:05 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Eric W. Biederman, (Tue Apr 29, 3:00 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Tue Apr 29, 4:04 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Eric W. Biederman, (Tue Apr 29, 4:29 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Tue Apr 29, 5:57 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Eric W. Biederman, (Tue Apr 29, 6:14 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Thomas Gleixner, (Tue Apr 29, 6:54 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Eric W. Biederman, (Tue Apr 29, 9:16 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Alan Cox, (Wed Apr 30, 5:57 am)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Ingo Molnar, (Tue Apr 29, 6:09 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Tue Apr 29, 6:18 pm)

[PATCH 1/2] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Tue Apr 29, 5:00 am)

[PATCH 1/2] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Tue Apr 29, 6:52 am)

[PATCH] x86: mtrr cleanup for converting continuous to discr..., Yinghai Lu, (Tue Apr 29, 11:25 pm)

[PATCH] x86: mtrr cleanup for converting continuous to discr..., Yinghai Lu, (Thu May 1, 4:00 am)

[PATCH] x86: mtrr cleanup for converting continuous to discr..., Yinghai Lu, (Thu May 1, 2:57 pm)

[PATCH] x86: mtrr cleanup for converting continuous to discr..., Yinghai Lu, (Thu May 1, 8:52 pm)

[PATCH] x86: mtrr cleanup for converting continuous to discr..., Yinghai Lu, (Fri May 2, 5:40 am)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., H. Peter Anvin, (Thu May 1, 3:42 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 5:02 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., H. Peter Anvin, (Thu May 1, 5:10 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 5:20 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., H. Peter Anvin, (Thu May 1, 5:26 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 5:31 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., H. Peter Anvin, (Thu May 1, 5:33 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 5:44 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., H. Peter Anvin, (Thu May 1, 5:49 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 6:52 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., H. Peter Anvin, (Thu May 1, 6:57 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 7:10 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Randy Dunlap, (Thu May 1, 11:09 am)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 12:38 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Mika Fischer, (Thu May 1, 8:09 am)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 12:35 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Mika Fischer, (Thu May 1, 12:59 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 1:40 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Gabriel C, (Thu May 1, 7:45 am)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 8:06 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Gabriel C, (Thu May 1, 8:29 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 8:35 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Gabriel C, (Thu May 1, 9:18 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Thu May 1, 9:55 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Ingo Molnar, (Wed Apr 30, 8:09 am)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Randy Dunlap, (Tue Apr 29, 4:46 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Tue Apr 29, 5:54 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Ingo Molnar, (Tue Apr 29, 9:07 am)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Tue Apr 29, 1:25 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Gabriel C, (Tue Apr 29, 5:47 am)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Tue Apr 29, 6:30 am)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Tue Apr 29, 6:56 am)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Gabriel C, (Tue Apr 29, 7:51 am)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Tue Apr 29, 1:11 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Gabriel C, (Tue Apr 29, 4:25 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Tue Apr 29, 5:49 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Gabriel C, (Tue Apr 29, 7:56 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Tue Apr 29, 8:13 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Gabriel C, (Tue Apr 29, 8:06 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Tue Apr 29, 8:38 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Gabriel C, (Tue Apr 29, 9:02 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Tue Apr 29, 11:00 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Tue Apr 29, 11:29 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Gabriel C, (Wed Apr 30, 12:12 am)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Wed Apr 30, 12:25 am)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Gabriel C, (Wed Apr 30, 8:04 am)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Yinghai Lu, (Wed Apr 30, 12:26 pm)

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous ..., Ingo Molnar, (Tue Apr 29, 7:26 am)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Andrew Morton, (Mon Apr 28, 10:42 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Mon Apr 28, 11:01 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Randy Dunlap, (Mon Apr 28, 6:36 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Mon Apr 28, 6:47 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Ingo Molnar, (Mon Apr 28, 4:15 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Yinghai Lu, (Mon Apr 28, 4:18 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Ingo Molnar, (Mon Apr 28, 4:29 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Ingo Molnar, (Mon Apr 28, 9:08 am)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Arjan van de Ven, (Mon Apr 28, 9:49 am)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Mika Fischer, (Mon Apr 28, 11:28 am)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Arjan van de Ven, (Mon Apr 28, 1:50 am)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Gabriel C, (Mon Apr 28, 12:01 pm)

Re: [PATCH] x86: mtrr cleanup for converting continuous to d..., Mika Fischer, (Mon Apr 28, 12:28 pm)


linux-kernel:
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Cabot, Mason B	Ext3 vs NTFS performance
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Alan Cox	[PATCH 00/76] Queued TTY Patches
git:
Nguyen Thai Ngoc Duy	Re: VCS comparison table
Ken Pratt	Re: pack operation is thrashing my server
Wink Saville	Using git with Eclipse
Bill Lear	Meaning of "fatal: protocol error: bad line length character"?
openbsd-misc:
Steve Shockley	Re: Real men don't attack straw men
Mayuresh Kathe	Re: What is our ultimate goal??
frantisek holop	booting openbsd on eee without cd-rom
Didier Wiroth	how can I "find xyz \| xargs tar" ... like gtar
linux-netdev:
David Miller	[GIT]: Networking
Sven Wegener	[PATCH 2/5] ipvs: Use ERR_PTR for returning errors from make_receive_sock() and ma...
Ingo Molnar	Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison overwritten
Herbert Xu	Re: [PATCH 2/3] [UDP]: Restore missing inDatagrams increments


Kernel Module Oops! TRICKY PROBLEM!	8 hours ago	Linux kernel
usb mic not detected	11 hours ago	Applications and Utilities
linux-2.6.10	18 hours ago	Linux kernel
How to detect usb device insertioin and removal event ?	21 hours ago	Linux general
Extended configuration Read/Write	22 hours ago	Windows
Add ext2 inode field	1 day ago	Linux kernel
the kernel how to power off the machine	1 day ago	Linux kernel
struct gendisk via request_queue	1 day ago	Linux kernel
page initialization during kernel initialization	2 days ago	Linux kernel
Read Transport Layer Data form network packets (tcp/ip)	3 days ago	Linux kernel

Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discrete layout v7

Online users