On Mon, 28 Apr 2008, Jeff Dike wrote:

quoted text
> On Sat, Apr 26, 2008 at 06:01:12PM +0800, WANG Cong wrote:
>> > +	/*
>> > +	 * When the stub stops, we find the following values on the
>> > +	 * beginning of the stack:
>> > +	 * (long) return_value
>> > +	 * (long) offset to failed sycall data (0 if no error)
>> > +	 */
>> > +	ret = *((unsigned long *) stack);
>> 
>> 
>> I am afraid the value will be truncated on 64bit machine, since
>> 'ret' is 'int' while 'stack' points to an 'unsigned long'.
>> 
>> Is this expected?
>
> That's dubious, but I don't think it breaks anything.  On LE, *(int *)
> and *(long *) will give you the same answer, and the value here is an
> error code, which fits into 32 bits.

So it's safe here.

OK. Thanks!

--
Hi, I'm a .signature virus, please copy/paste me to help me spread
all over the world.
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/