PTRACE_{READ,WRITE}{TEXT,DATA}

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Roland McGrath <roland@...>
Cc: David S. Miller <davem@...>, Linux Kernel list <linux-kernel@...>, Rik van Riel <riel@...>
Date: Monday, April 28, 2008 - 11:54 pm

Hi Roland, David !

I noticed kernel/ptrace.c has ptrace_readdata/writedata functions that
are only used by sparc and sparc64 which implements the ptrace requests
PTRACE_READ_DATA, PTRACE_WRITE_DATA (and _TEXT variants).

Any reason not to make everybody benefit from these and moving the sparc
implementation to the generic ptrace_request (&compat) ?

It's more efficient than read/writing one word at a time... I thought
about it in the light of some work Rik is doing to make
access_process_vm useable on video ram mappings done by the X server...

If you are ok, I'll do a patch.

Cheers,
Ben

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
PTRACE_{READ,WRITE}{TEXT,DATA}, Benjamin Herrenschmidt, (Mon Apr 28, 11:54 pm)
Re: PTRACE_{READ,WRITE}{TEXT,DATA}, Roland McGrath, (Tue Apr 29, 6:07 pm)
Re: PTRACE_{READ,WRITE}{TEXT,DATA}, Benjamin Herrenschmidt, (Tue Apr 29, 8:06 pm)
Re: PTRACE_{READ,WRITE}{TEXT,DATA}, Roland McGrath, (Tue Apr 29, 9:32 pm)
Re: PTRACE_{READ,WRITE}{TEXT,DATA}, David Miller, (Tue Apr 29, 12:34 am)
Re: PTRACE_{READ,WRITE}{TEXT,DATA}, Benjamin Herrenschmidt, (Tue Apr 29, 1:06 am)
Re: PTRACE_{READ,WRITE}{TEXT,DATA}, Rik van Riel, (Tue Apr 29, 12:44 am)
Re: PTRACE_{READ,WRITE}{TEXT,DATA}, Benjamin Herrenschmidt, (Tue Apr 29, 1:06 am)