Home » Mailing list archives » linux-kernel » 2008 » April » 29

Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Al Viro
Subject: Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline
Date: Monday, April 28, 2008 - 6:12 pm

On Mon, Apr 28, 2008 at 05:41:11PM -0700, Linus Torvalds wrote:


AFAICS, it's a gcc bug.  We have
extern struct block_device *I_BDEV(struct inode *inode);
followed by
inline struct block_device *I_BDEV(struct inode *inode)
{
...
}

and presence of declaration with extern within the same translation unit
means that definition we have here is an external one, per 6.7.4.  It's
perfectly legitimate and gcc has no business complaining about inline
here; moreover, example in 6.7.4(7) is essentially the same thing...
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[git pull] generic bitops, Ingo Molnar, (Thu Apr 24, 2:57 pm)
Re: [git pull] generic bitops, Linus Torvalds, (Thu Apr 24, 3:14 pm)
Re: [git pull] generic bitops, Harvey Harrison, (Thu Apr 24, 3:41 pm)
[PATCH] x86, bitops: select the generic bitmap search func ..., Alexander van Heukelum, (Fri Apr 25, 4:12 am)
[git pull] generic bitops, take 2, Ingo Molnar, (Sat Apr 26, 8:15 am)
Re: [git pull] generic bitops, take 2, Linus Torvalds, (Sat Apr 26, 10:03 am)
Re: [git pull] generic bitops, take 2, Ingo Molnar, (Sat Apr 26, 10:22 am)
Re: [git pull] generic bitops, take 2, Ingo Molnar, (Sat Apr 26, 10:28 am)
Re: [git pull] generic bitops, take 2, Sam Ravnborg, (Sat Apr 26, 10:32 am)
Re: [git pull] generic bitops, take 2, Sam Ravnborg, (Sat Apr 26, 10:34 am)
[git pull] generic bitops, take 3, Ingo Molnar, (Sat Apr 26, 10:50 am)
Re: [git pull] generic bitops, take 2, Miklos Vajna, (Sat Apr 26, 10:51 am)
[2.6 patch] mm/filemap.c:generic_write_checks() mustn't be ..., Adrian Bunk, (Mon Apr 28, 8:38 am)
[2.6 patch] fs/buffer.c:init_buffer() mustn't be inline, Adrian Bunk, (Mon Apr 28, 8:38 am)
[2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Adrian Bunk, (Mon Apr 28, 8:38 am)
[2.6 patch] block/blk-barrier.c:blk_ordered_cur_seq() must ..., Adrian Bunk, (Mon Apr 28, 8:38 am)
[2.6 patch] net/ipv4/ip_output.c:ip_send_check() mustn't b ..., Adrian Bunk, (Mon Apr 28, 8:38 am)
[2.6 patch] reiserfs: some functions mustn't be inline, Adrian Bunk, (Mon Apr 28, 8:38 am)
[2.6 patch] fs/udf/partition.c:udf_get_pblock() mustn't be ..., Adrian Bunk, (Mon Apr 28, 8:38 am)
Re: [2.6 patch] fs/buffer.c:init_buffer() mustn't be inline, Linus Torvalds, (Mon Apr 28, 9:01 am)
Re: [2.6 patch] fs/udf/partition.c:udf_get_pblock() mustn' ..., Jan Kara, (Mon Apr 28, 9:47 am)
Re: [2.6 patch] fs/buffer.c:init_buffer() mustn't be inline, Adrian Bunk, (Mon Apr 28, 9:48 am)
Re: [2.6 patch] fs/buffer.c:init_buffer() mustn't be inline, Linus Torvalds, (Mon Apr 28, 9:58 am)
Re: [git pull] generic bitops, take 2, Jeff Dike, (Mon Apr 28, 10:26 am)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Linus Torvalds, (Mon Apr 28, 5:41 pm)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Al Viro, (Mon Apr 28, 6:12 pm)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Linus Torvalds, (Mon Apr 28, 6:21 pm)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Jeff Dike, (Mon Apr 28, 7:32 pm)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Sam Ravnborg, (Mon Apr 28, 9:57 pm)
Re: [2.6 patch] block/blk-barrier.c:blk_ordered_cur_seq() ..., Jens Axboe, (Tue Apr 29, 12:46 am)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Adrian Bunk, (Tue Apr 29, 1:06 am)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Sam Ravnborg, (Tue Apr 29, 1:17 am)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Adrian Bunk, (Tue Apr 29, 2:03 am)
Re: [2.6 patch] reiserfs: some functions mustn't be inline, Edward Shishkin, (Tue Apr 29, 3:43 pm)