This is a note to let you know that I've just added the patch titled
Subject: USB: mos7840: test and propagate set_uart_reg return value
to my gregkh-2.6 tree. Its filename is
usb-mos7840-test-and-propagate-set_uart_reg-return-value.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
From 12o3l@tiscali.nl Wed Apr 16 21:16:30 2008
From: Roel Kluin <12o3l@tiscali.nl>
Date: Thu, 17 Apr 2008 06:16:24 +0200
Subject: USB: mos7840: test and propagate set_uart_reg return value
To: Greg KH <greg@kroah.com>, linux-usb@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Message-ID: <4806CF18.2050403@tiscali.nl>
The test for an mos7840_set_uart_reg() error return value only works when
status is signed. propagate its error value.
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Cc: SL Baur <steve@xemacs.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/usb/serial/mos7840.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -1713,7 +1713,7 @@ static int mos7840_tiocmset(struct usb_s
{
struct moschip_port *mos7840_port;
unsigned int mcr;
- unsigned int status;
+ int status;
dbg("%s - port %d", __func__, port->number);
@@ -1740,11 +1740,10 @@ static int mos7840_tiocmset(struct usb_s
mos7840_port->shadowMCR = mcr;
- status = 0;
status = mos7840_set_uart_reg(port, MODEM_CONTROL_REGISTER, mcr);
if (status < 0) {
dbg("setting MODEM_CONTROL_REGISTER Failed\n");
- return -1;
+ return status;
}
return 0;
Patches currently in gregkh-2.6 which might be from 12o3l@tiscali.nl are
usb/usb-mos7840-test-and-propagate-set_uart_reg-return-value.patch
--
