Re: [PATCH 1/1] x86: fix text_poke

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Mathieu Desnoyers <mathieu.desnoyers@...>
Cc: Linus Torvalds <torvalds@...>, H. Peter Anvin <hpa@...>, Andi Kleen <andi@...>, Ingo Molnar <mingo@...>, Jiri Slaby <jirislaby@...>, David Miller <davem@...>, <zdenek.kabelac@...>, <rjw@...>, <paulmck@...>, <akpm@...>, <linux-ext4@...>, <herbert@...>, <penberg@...>, <clameter@...>, <linux-kernel@...>, <pageexec@...>
Date: Monday, April 28, 2008 - 5:02 pm

Mathieu Desnoyers wrote:

That in itself is pretty significant.  If that value would otherwise be 
constant folded or strength-reduced away, you're putting a big 
limitation on what the compiler can do.  The mere fact that its 
necessary to do something to preserve many values shows how much the 
compiler transforms the code away from what's in the source, and 
specifically referencing otherwise unused intermediates inhibits that.

In other words, if you weren't preventing optimisations, you wouldn't 
need to preserve values as much, because the optimiser wouldn't be 
getting rid of them.  If you need to preserve lots of values, you're 
necessarily preventing the optimiser from doing its job.

    J
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-git1: Solid hang on HP nx6325 (64-bit), Rafael J. Wysocki, (Sat Apr 19, 9:22 am)
2.6.25-git2: BUG: unable to handle kernel paging request at ..., Rafael J. Wysocki, (Sun Apr 20, 3:04 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Mon Apr 21, 12:12 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Mon Apr 21, 2:22 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Mon Apr 21, 1:19 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Mon Apr 21, 8:54 pm)
[PATCH 1/1] x86: fix text_poke, Jiri Slaby, (Sun Apr 27, 8:51 pm)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 11:03 am)
Re: [PATCH 1/1] x86: fix text_poke, David Miller, (Fri Apr 25, 4:18 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 11:19 am)
Re: [PATCH 1/1] x86: fix text_poke, Andi Kleen, (Fri Apr 25, 11:27 am)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 11:26 am)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 11:33 am)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 11:54 am)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 11:59 am)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 12:11 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 11:50 am)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 12:11 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 11:57 am)
Re: [PATCH 1/1] x86: fix text_poke, Pavel Machek, (Fri Apr 25, 2:53 pm)
Re: [PATCH 1/1] x86: fix text_poke, Andi Kleen, (Fri Apr 25, 11:48 am)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 12:06 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 12:22 pm)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 12:37 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 12:52 pm)
Re: [PATCH 1/1] x86: fix text_poke, Andi Kleen, (Fri Apr 25, 12:56 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 12:45 pm)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 12:51 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 1:02 pm)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 1:13 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 1:53 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 2:13 pm)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 2:09 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 2:19 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 2:56 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 2:04 pm)
Re: [PATCH 1/1] x86: fix text_poke, Andi Kleen, (Fri Apr 25, 1:26 pm)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 1:29 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 12:43 pm)
Re: [PATCH 1/1] x86: fix text_poke, Andi Kleen, (Fri Apr 25, 12:19 pm)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 12:24 pm)
Re: [PATCH 1/1] x86: fix text_poke, Jeremy Fitzhardinge, (Fri Apr 25, 2:13 pm)
Re: [PATCH 1/1] x86: fix text_poke, Nick Piggin, (Sun May 4, 10:36 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 12:33 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 12:30 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 12:42 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 1:09 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 2:37 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 4:18 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 4:37 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 4:41 pm)
Re: [PATCH 1/1] x86: fix text_poke, David Miller, (Fri Apr 25, 5:02 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 5:11 pm)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 4:51 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 5:12 pm)
Re: [PATCH 1/1] x86: fix text_poke, Jeremy Fitzhardinge, (Sat Apr 26, 2:50 am)
Re: [PATCH 1/1] x86: fix text_poke, Masami Hiramatsu, (Sun Apr 27, 8:49 pm)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 6:04 pm)
Re: [PATCH 1/1] x86: fix text_poke, Frank Ch. Eigler, (Thu Jun 5, 1:44 pm)
Re: [PATCH 1/1] x86: fix text_poke, Frank Ch. Eigler, (Fri Apr 25, 10:12 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 7:00 pm)
Re: [PATCH 1/1] x86: fix text_poke, Jeremy Fitzhardinge, (Fri Apr 25, 7:13 pm)
Re: [PATCH 1/1] x86: fix text_poke, Masami Hiramatsu, (Fri Apr 25, 7:34 pm)
Re: [PATCH 1/1] x86: fix text_poke, Jeremy Fitzhardinge, (Sat Apr 26, 2:21 am)
Re: [PATCH 1/1] x86: fix text_poke, Arnaldo Carvalho de Melo, (Sat Apr 26, 7:56 am)
Re: [PATCH 1/1] x86: fix text_poke, Jeremy Fitzhardinge, (Sat Apr 26, 7:38 pm)
Re: [PATCH 1/1] x86: fix text_poke, Arnaldo Carvalho de Melo, (Sat Apr 26, 9:00 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 5:15 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 5:47 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 6:07 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 6:30 pm)
Re: [PATCH 1/1] x86: fix text_poke, Linus Torvalds, (Fri Apr 25, 6:36 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Mon Apr 28, 4:43 pm)
Re: [PATCH 1/1] x86: fix text_poke, Jeremy Fitzhardinge, (Mon Apr 28, 5:02 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Sun May 4, 11:03 am)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Sun May 4, 12:18 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Mon Apr 28, 4:21 pm)
Re: [PATCH 1/1] x86: fix text_poke, Jeremy Fitzhardinge, (Mon Apr 28, 4:55 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Mon Apr 28, 5:01 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Mon Apr 28, 6:42 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 6:38 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 3:19 pm)
Re: [PATCH 1/1] x86: fix text_poke, Mathieu Desnoyers, (Fri Apr 25, 4:04 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 4:09 pm)
Re: [PATCH 1/1] x86: fix text_poke, H. Peter Anvin, (Fri Apr 25, 2:47 pm)
Re: [PATCH 1/1] x86: fix text_poke, Ingo Molnar, (Fri Apr 25, 11:32 am)
Re: [PATCH 1/1] x86: fix text_poke, Andi Kleen, (Fri Apr 25, 11:17 am)
Re: [PATCH 1/1] x86: fix text_poke, Christoph Lameter, (Fri Apr 25, 3:36 pm)
Re: [PATCH 1/1] x86: fix text_poke, Andi Kleen, (Sat Apr 26, 5:59 am)
VIRTUAL_BUG_ON(), Christoph Lameter, (Mon Apr 28, 4:24 pm)
[RFC 1/1] mm: add virt to phys debug, Jiri Slaby, (Thu May 1, 3:22 pm)
Re: [RFC 1/1] mm: add virt to phys debug, Christoph Lameter, (Thu May 1, 4:18 pm)
Re: [RFC 1/1] mm: add virt to phys debug, Jiri Slaby, (Tue May 13, 10:38 am)
Re: [RFC 1/1] mm: add virt to phys debug, Jiri Slaby, (Tue May 6, 5:54 pm)
Re: [RFC 1/1] mm: add virt to phys debug, Christoph Lameter, (Wed May 7, 1:30 pm)
Re: [PATCH 1/1] x86: fix text_poke, Jiri Slaby, (Sat Apr 26, 7:16 am)
Re: [PATCH 1/1] x86: fix text_poke, Andi Kleen, (Sat Apr 26, 7:34 am)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Fri Apr 25, 11:30 am)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Christoph Lameter, (Wed Apr 23, 3:05 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Christoph Lameter, (Wed Apr 23, 3:28 pm)
device_pm_add (was: Re: 2.6.25-git2: BUG: unable to handle k..., Rafael J. Wysocki, (Tue Apr 22, 4:34 pm)
Re: device_pm_add (was: Re: 2.6.25-git2: BUG: unable to hand..., Rafael J. Wysocki, (Tue Apr 22, 8:50 pm)
Re: device_pm_add (was: Re: 2.6.25-git2: BUG: unable to hand..., Rafael J. Wysocki, (Tue Apr 22, 6:48 pm)
Re: device_pm_add (was: Re: 2.6.25-git2: BUG: unable to hand..., Rafael J. Wysocki, (Tue Apr 22, 4:57 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Tue Apr 22, 5:46 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Mon Apr 21, 9:30 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Mon Apr 21, 9:15 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Paul E. McKenney, (Sun Apr 20, 10:08 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Paul E. McKenney, (Mon Apr 21, 12:59 am)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Mon Apr 21, 12:24 pm)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Mon Apr 21, 9:35 am)
Re: 2.6.25-git2: BUG: unable to handle kernel paging request..., Rafael J. Wysocki, (Sun Apr 20, 3:14 pm)