Home » Mailing list archives » linux-kernel » 2008 » April » 28

Re: [2.6 patch] fs/buffer.c:init_buffer() mustn't be inline

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Adrian Bunk <bunk@...>
Cc: Ingo Molnar <mingo@...>, Linux Kernel Mailing List <linux-kernel@...>, Andrew Morton <akpm@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>, Alexander van Heukelum <heukelum@...>, <jdike@...>
Subject: Re: [2.6 patch] fs/buffer.c:init_buffer() mustn't be inline
Date: Monday, April 28, 2008 - 12:58 pm

On Mon, 28 Apr 2008, Adrian Bunk wrote:

But when doing this, MARK IT LOUDLY AS A GCC BUG!

The thing is, reading that log message, it was not at all clear why that 
change was made. Please make it clear why, rather than quoting a totally 
useless error message that doesn't actually tell what is going on.

I agree that having work-arounds for compiler bugs is worth it (assuming 
the version is common enough to worry about), but I also don't want to 
have unexplained commits doing something that on the face of it is just 
odd

Put another way: looking at the actual diff and looking at the commit 
message, the only sane reaction from somebody who knows the code is: 
"Whaa? WTF?". Saying "This is a gcc bug" would have turned that "WTF?" 
into a "Oh, ok then".

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[git pull] generic bitops, Ingo Molnar, (Thu Apr 24, 5:57 pm)
Re: [git pull] generic bitops, Linus Torvalds, (Thu Apr 24, 6:14 pm)
[git pull] generic bitops, take 2, Ingo Molnar, (Sat Apr 26, 11:15 am)
Re: [git pull] generic bitops, take 2, Linus Torvalds, (Sat Apr 26, 1:03 pm)
Re: [git pull] generic bitops, take 2, Sam Ravnborg, (Sat Apr 26, 1:34 pm)
Re: [git pull] generic bitops, take 2, Ingo Molnar, (Sat Apr 26, 1:22 pm)
Re: [git pull] generic bitops, take 2, Jeff Dike, (Mon Apr 28, 1:26 pm)
[2.6 patch] fs/udf/partition.c:udf_get_pblock() mustn't be i..., Adrian Bunk, (Mon Apr 28, 11:38 am)
Re: [2.6 patch] fs/udf/partition.c:udf_get_pblock() mustn't ..., Jan Kara, (Mon Apr 28, 12:47 pm)
[2.6 patch] reiserfs: some functions mustn't be inline, Adrian Bunk, (Mon Apr 28, 11:38 am)
Re: [2.6 patch] reiserfs: some functions mustn't be inline, Edward Shishkin, (Tue Apr 29, 6:43 pm)
[2.6 patch] net/ipv4/ip_output.c:ip_send_check() mustn't be ..., Adrian Bunk, (Mon Apr 28, 11:38 am)
[2.6 patch] block/blk-barrier.c:blk_ordered_cur_seq() mustn'..., Adrian Bunk, (Mon Apr 28, 11:38 am)
Re: [2.6 patch] block/blk-barrier.c:blk_ordered_cur_seq() mu..., Jens Axboe, (Tue Apr 29, 3:46 am)
[2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Adrian Bunk, (Mon Apr 28, 11:38 am)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Linus Torvalds, (Mon Apr 28, 8:41 pm)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Adrian Bunk, (Tue Apr 29, 4:06 am)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Sam Ravnborg, (Tue Apr 29, 4:17 am)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Adrian Bunk, (Tue Apr 29, 5:03 am)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Jeff Dike, (Mon Apr 28, 10:32 pm)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Sam Ravnborg, (Tue Apr 29, 12:57 am)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Al Viro, (Mon Apr 28, 9:12 pm)
Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline, Linus Torvalds, (Mon Apr 28, 9:21 pm)
[2.6 patch] fs/buffer.c:init_buffer() mustn't be inline, Adrian Bunk, (Mon Apr 28, 11:38 am)
Re: [2.6 patch] fs/buffer.c:init_buffer() mustn't be inline, Linus Torvalds, (Mon Apr 28, 12:01 pm)
Re: [2.6 patch] fs/buffer.c:init_buffer() mustn't be inline, Adrian Bunk, (Mon Apr 28, 12:48 pm)
Re: [2.6 patch] fs/buffer.c:init_buffer() mustn't be inline, Linus Torvalds, (Mon Apr 28, 12:58 pm)
[2.6 patch] mm/filemap.c:generic_write_checks() mustn't be i..., Adrian Bunk, (Mon Apr 28, 11:38 am)
Re: [git pull] generic bitops, take 2, Miklos Vajna, (Sat Apr 26, 1:51 pm)
Re: [git pull] generic bitops, take 2, Sam Ravnborg, (Sat Apr 26, 1:32 pm)
Re: [git pull] generic bitops, take 2, Ingo Molnar, (Sat Apr 26, 1:28 pm)
[git pull] generic bitops, take 3, Ingo Molnar, (Sat Apr 26, 1:50 pm)
[PATCH] x86, bitops: select the generic bitmap search functi..., Alexander van Heukelum, (Fri Apr 25, 7:12 am)
Re: [git pull] generic bitops, Harvey Harrison, (Thu Apr 24, 6:41 pm)