login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
28
Re: [PATCH] sched: missing locking in sched_domains code
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Andrew Morton
Subject:
Re: [PATCH] sched: missing locking in sched_domains code
Date: Monday, April 28, 2008 - 2:31 am
On Mon, 28 Apr 2008 11:17:45 +0200 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
quoted text
> On Mon, Apr 28, 2008 at 01:57:23AM -0700, Andrew Morton wrote: > > On Mon, 28 Apr 2008 10:49:04 +0200 Heiko Carstens <heiko.carstens@de.ibm.com> wrote: > > > /* doms_cur_mutex serializes access to doms_cur[] array */ > > > -static DEFINE_MUTEX(doms_cur_mutex); > > > +static DEFINE_MUTEX(sched_domains_mutex); > > > > The comment refers to a no-longer-existing lock, and no longer correctly > > describes the lock's usage. > > version 42. Please feel free to change the comment if you think it could > be better :)
Actually, it's a pretty bad comment ;)
quoted text
> +/* sched_domains_mutex serializes calls to arch_init_sched_domains, > + * detach_destroy_domains and partition_sched_domains. > + */
locks protect *data*, not "calls". This matters. Which data is actually protected by this lock?? --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] sched: missing locking in sched_domains code
, Heiko Carstens
, (Sun Apr 27, 2:12 pm)
Re: [PATCH] sched: missing locking in sched_domains code
, Andrew Morton
, (Sun Apr 27, 6:39 pm)
Re: [PATCH] sched: missing locking in sched_domains code
, Heiko Carstens
, (Mon Apr 28, 12:09 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Ingo Molnar
, (Mon Apr 28, 12:24 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Andrew Morton
, (Mon Apr 28, 12:28 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Heiko Carstens
, (Mon Apr 28, 12:52 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Heiko Carstens
, (Mon Apr 28, 1:11 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Ingo Molnar
, (Mon Apr 28, 1:32 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Heiko Carstens
, (Mon Apr 28, 1:49 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Andrew Morton
, (Mon Apr 28, 1:57 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Heiko Carstens
, (Mon Apr 28, 2:17 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Andrew Morton
, (Mon Apr 28, 2:31 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Heiko Carstens
, (Mon Apr 28, 2:33 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Ingo Molnar
, (Mon Apr 28, 5:27 am)
Re: [PATCH] sched: missing locking in sched_domains code
, Ingo Molnar
, (Mon Apr 28, 6:13 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Benjamin Herrenschmidt
Re: [PATCH 1/4] hvc_console: do not set low_latency
Russell King
Re: ARM defconfig files
Carsten Otte
Re: [patch] ext2: xip check fix
Jordan Crouse
Re: 2.6.25-mm1
James Morris
Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook
git
:
Felipe Contreras
Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Johannes Schindelin
[PATCH] fetch: refuse to fetch into the current branch in a non-bare repository
Johannes Schindelin
Re: [PATCH] Fix install-doc-quick target
Peter Oberndorfer
Subject: [PATCH] fix stg edit command
Nicolas Pitre
Re: About git and the use of SHA-1
linux-netdev
:
Ursula Braun
[patch 2/8] [PATCH] af_iucv: sync sk shutdown flag if iucv path is quiesced
Andi Kleen
Re: RFC: Nagle latency tuning
Gary Thomas
Re: Marvell 88E609x switch?
David Miller
Re: [RFC 0/5] generic rx recycling
Chuck Lever
Re: [RFC] ipv6: Change %pI6 format to output compacted addresses?
dragonflybsd-user
:
Andreas Hauser
Re: Transset.
Tomas
usb printer Brother HL-2030 and DragonFly
Matthew Dillon
Re: DragonFlyBSD not in compliance with RFC 1122
Nikolai Lifanov
pkgsrc issues
Jonas
Re: New to DragonFly...
dragonflybsd-submit
:
Ilya Dryomov
git: HAMMER - Add live_dedup_cache_size sysctl
Matthew Dillon
git: MBUF - Account for failed allocations so netstat -m reports properly.
Simon Schubert
git: make.conf(5): mention STATIC_LOCALES
Matthias Schmidt
cvs commit: src/sys/net bpf.c bpf.h bpfdesc.h
Simon Schubert
git: Revert "Increase the default TCP maximum segment size from 512 to 1460."
Colocation donated by:
Syndicate