login
Header Space

 
 

Re: [PATCH] sched: missing locking in sched_domains code

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Heiko Carstens <heiko.carstens@...>
Cc: Andrew Morton <akpm@...>, Gautham R Shenoy <ego@...>, Paul Jackson <pj@...>, <linux-kernel@...>
Date: Monday, April 28, 2008 - 4:32 am

* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:



thanks, that looks a lot more clean already. May i ask for another 
thing, if you are hacking on this anyway? Please get rid of the 
lock_doms_cur() complication now that it's not conditional - an open 
coded mutex_lock(&sched_doms_mutex) looks more readable - it gives a 
clear idea about what's happening. Also, please rename sched_doms_mutex 
to something less tongue-twisting - such as sched_domains_mutex. Hm?

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] sched: missing locking in sched_domains code, Heiko Carstens, (Sun Apr 27, 5:12 pm)
Re: [PATCH] sched: missing locking in sched_domains code, Andrew Morton, (Sun Apr 27, 9:39 pm)
Re: [PATCH] sched: missing locking in sched_domains code, Heiko Carstens, (Mon Apr 28, 3:09 am)
Re: [PATCH] sched: missing locking in sched_domains code, Andrew Morton, (Mon Apr 28, 3:28 am)
Re: [PATCH] sched: missing locking in sched_domains code, Heiko Carstens, (Mon Apr 28, 3:52 am)
Re: [PATCH] sched: missing locking in sched_domains code, Heiko Carstens, (Mon Apr 28, 4:11 am)
Re: [PATCH] sched: missing locking in sched_domains code, Ingo Molnar, (Mon Apr 28, 4:32 am)
Re: [PATCH] sched: missing locking in sched_domains code, Heiko Carstens, (Mon Apr 28, 4:49 am)
Re: [PATCH] sched: missing locking in sched_domains code, Andrew Morton, (Mon Apr 28, 4:57 am)
Re: [PATCH] sched: missing locking in sched_domains code, Heiko Carstens, (Mon Apr 28, 5:17 am)
Re: [PATCH] sched: missing locking in sched_domains code, Andrew Morton, (Mon Apr 28, 5:31 am)
Re: [PATCH] sched: missing locking in sched_domains code, Heiko Carstens, (Mon Apr 28, 5:33 am)
speck-geostationary