Re: [patch] x86, voyager: fix ioremap_nocache()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: James Bottomley <James.Bottomley@...>
Cc: Thomas Gleixner <tglx@...>, linux-kernel <linux-kernel@...>, H. Peter Anvin <hpa@...>, David S. Miller <davem@...>
Date: Sunday, April 27, 2008 - 7:18 pm

* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:


ok, but that rather crutial piece of information was not at all clear 
from your mail ... ;-)


... but the PAT patchset was all around lkml. The ioremap change was 
trivial, went into v2.6.25 and was discussed on lkml:

  http://lkml.org/lkml/2008/1/25/287

" that's why we changed all ioremaps to default to cache-disabled (PCD)
  in latest x86.git as well. For years the x86 architecture set the
  ioremap pagetable entries to cacheable by default and only the MTRRs
  (and the BIOS writers) saved us from trouble. Now we try to be a bit
  more defensive and avoid "BIOS bug causes only Linux to crash and burn
  while other OSs work fine" type of scenarios. "

i could have included the actual patch in that mail i guess - but this 
was hardly an unreviewed change and you never showed interest in the PAT 
threads on lkml (or much interest in x86 threads for that matter) so 
would it have made any difference in practice?

The commit was mentioned in the pull request to Linus as well, which was 
Cc:-ed to lkml. The commit was upstream about 3 months before you 
noticed that it broke Voyager.

But, we'd not mind at all posting 1000 x86.git patches to lkml (or 
another list) every 3 months (or more frequently), if people request 
that.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Breakage caused by unreviewed patch in x86 tree, James Bottomley, (Sun Apr 27, 4:51 pm)
Re: Breakage caused by unreviewed patch in x86 tree, Arjan van de Ven, (Sun Apr 27, 6:58 pm)
Re: Breakage caused by unreviewed patch in x86 tree, James Bottomley, (Sun Apr 27, 7:03 pm)
Re: Breakage caused by unreviewed patch in x86 tree, H. Peter Anvin, (Sun Apr 27, 7:17 pm)
Re: Breakage caused by unreviewed patch in x86 tree, Arjan van de Ven, (Sun Apr 27, 7:11 pm)
Re: Breakage caused by unreviewed patch in x86 tree, David Miller, (Sun Apr 27, 7:00 pm)
Re: Breakage caused by unreviewed patch in x86 tree, Arjan van de Ven, (Sun Apr 27, 7:07 pm)
Re: Breakage caused by unreviewed patch in x86 tree, H. Peter Anvin, (Sun Apr 27, 6:00 pm)
Re: Breakage caused by unreviewed patch in x86 tree, James Bottomley, (Sun Apr 27, 6:10 pm)
Re: Breakage caused by unreviewed patch in x86 tree, H. Peter Anvin, (Sun Apr 27, 6:13 pm)
Re: Breakage caused by unreviewed patch in x86 tree, James Bottomley, (Sun Apr 27, 6:18 pm)
Re: Breakage caused by unreviewed patch in x86 tree, H. Peter Anvin, (Sun Apr 27, 6:31 pm)
[patch] x86, voyager: fix ioremap_nocache(), Ingo Molnar, (Sun Apr 27, 5:48 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), James Bottomley, (Sun Apr 27, 6:34 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Jeff Garzik, (Sun Apr 27, 6:39 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Arjan van de Ven, (Mon Apr 28, 10:10 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), James Bottomley, (Mon Apr 28, 10:29 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), Arjan van de Ven, (Mon Apr 28, 11:07 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Mon Apr 28, 3:59 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Thomas Gleixner, (Sun Apr 27, 7:01 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), David Miller, (Sun Apr 27, 6:46 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Arjan van de Ven, (Sun Apr 27, 7:01 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), James Bottomley, (Wed Apr 30, 5:44 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Wed Apr 30, 6:39 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Jeff Garzik, (Sun Apr 27, 6:53 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 6:56 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Jeff Garzik, (Sun Apr 27, 7:02 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Arjan van de Ven, (Sun Apr 27, 7:14 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), David Miller, (Sun Apr 27, 6:59 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 6:52 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Jeff Garzik, (Sun Apr 27, 7:34 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 7:39 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), David Miller, (Sun Apr 27, 6:58 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 7:04 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Eric W. Biederman, (Wed Apr 30, 4:35 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 6:44 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), James Bottomley, (Sun Apr 27, 6:05 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Ingo Molnar, (Sun Apr 27, 7:18 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Christoph Hellwig, (Mon Apr 28, 2:10 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Mon Apr 28, 12:55 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), David Miller, (Sun Apr 27, 7:31 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Alan Cox, (Mon Apr 28, 5:01 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), David Miller, (Mon Apr 28, 5:17 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), Ingo Molnar, (Mon Apr 28, 7:50 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), Adrian Bunk, (Mon Apr 28, 5:48 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), Rik van Riel, (Sun Apr 27, 8:31 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Al Viro, (Sun Apr 27, 8:45 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 8:52 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Ingo Molnar, (Sun Apr 27, 6:41 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Willy Tarreau, (Sun Apr 27, 6:36 pm)
Re: Breakage caused by unreviewed patch in x86 tree, David Miller, (Sun Apr 27, 4:53 pm)