Re: Breakage caused by unreviewed patch in x86 tree

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Miller <davem@...>
Cc: <James.Bottomley@...>, <mingo@...>, <tglx@...>, <linux-kernel@...>
Date: Sunday, April 27, 2008 - 7:07 pm

On Sun, 27 Apr 2008 16:00:41 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:


ok on a process side it is basically a "go from 99.9% to 100%" bugfix ;(

Anyone who claims that ioremap() on x86 was cached before doesn't understand the issue,
it was NOT cached. It was "almost always uncached". The bugfix here is to take away the
"almost" part.
Should that have been posted to lkml more vocally? Wouldn't have hurt. No argument about that.
Is it as big a deal as this thread makes it sound? Absolutely not! The change in behavior
or even semantics is almost zero.  


-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Breakage caused by unreviewed patch in x86 tree, James Bottomley, (Sun Apr 27, 4:51 pm)
Re: Breakage caused by unreviewed patch in x86 tree, Arjan van de Ven, (Sun Apr 27, 6:58 pm)
Re: Breakage caused by unreviewed patch in x86 tree, James Bottomley, (Sun Apr 27, 7:03 pm)
Re: Breakage caused by unreviewed patch in x86 tree, H. Peter Anvin, (Sun Apr 27, 7:17 pm)
Re: Breakage caused by unreviewed patch in x86 tree, Arjan van de Ven, (Sun Apr 27, 7:11 pm)
Re: Breakage caused by unreviewed patch in x86 tree, David Miller, (Sun Apr 27, 7:00 pm)
Re: Breakage caused by unreviewed patch in x86 tree, Arjan van de Ven, (Sun Apr 27, 7:07 pm)
Re: Breakage caused by unreviewed patch in x86 tree, H. Peter Anvin, (Sun Apr 27, 6:00 pm)
Re: Breakage caused by unreviewed patch in x86 tree, James Bottomley, (Sun Apr 27, 6:10 pm)
Re: Breakage caused by unreviewed patch in x86 tree, H. Peter Anvin, (Sun Apr 27, 6:13 pm)
Re: Breakage caused by unreviewed patch in x86 tree, James Bottomley, (Sun Apr 27, 6:18 pm)
Re: Breakage caused by unreviewed patch in x86 tree, H. Peter Anvin, (Sun Apr 27, 6:31 pm)
[patch] x86, voyager: fix ioremap_nocache(), Ingo Molnar, (Sun Apr 27, 5:48 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), James Bottomley, (Sun Apr 27, 6:34 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Jeff Garzik, (Sun Apr 27, 6:39 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Arjan van de Ven, (Mon Apr 28, 10:10 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), James Bottomley, (Mon Apr 28, 10:29 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), Arjan van de Ven, (Mon Apr 28, 11:07 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Mon Apr 28, 3:59 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Thomas Gleixner, (Sun Apr 27, 7:01 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), David Miller, (Sun Apr 27, 6:46 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Arjan van de Ven, (Sun Apr 27, 7:01 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), James Bottomley, (Wed Apr 30, 5:44 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Wed Apr 30, 6:39 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Jeff Garzik, (Sun Apr 27, 6:53 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 6:56 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Jeff Garzik, (Sun Apr 27, 7:02 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Arjan van de Ven, (Sun Apr 27, 7:14 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), David Miller, (Sun Apr 27, 6:59 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 6:52 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Jeff Garzik, (Sun Apr 27, 7:34 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 7:39 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), David Miller, (Sun Apr 27, 6:58 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 7:04 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Eric W. Biederman, (Wed Apr 30, 4:35 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 6:44 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), James Bottomley, (Sun Apr 27, 6:05 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Ingo Molnar, (Sun Apr 27, 7:18 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Christoph Hellwig, (Mon Apr 28, 2:10 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Mon Apr 28, 12:55 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), David Miller, (Sun Apr 27, 7:31 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Alan Cox, (Mon Apr 28, 5:01 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), David Miller, (Mon Apr 28, 5:17 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), Ingo Molnar, (Mon Apr 28, 7:50 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), Adrian Bunk, (Mon Apr 28, 5:48 am)
Re: [patch] x86, voyager: fix ioremap_nocache(), Rik van Riel, (Sun Apr 27, 8:31 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Al Viro, (Sun Apr 27, 8:45 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), H. Peter Anvin, (Sun Apr 27, 8:52 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Ingo Molnar, (Sun Apr 27, 6:41 pm)
Re: [patch] x86, voyager: fix ioremap_nocache(), Willy Tarreau, (Sun Apr 27, 6:36 pm)
Re: Breakage caused by unreviewed patch in x86 tree, David Miller, (Sun Apr 27, 4:53 pm)