* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

quoted text
> >  		request_resource(&iomem_resource, &res);
> >  		voyager_SUS = (struct voyager_SUS *)
> > -		    ioremap(addr, 0x400);
> > +		    ioremap_cache(addr, 0x400);
> 
> Actually, no ... wrong ioremap.  That one is the SUS clickmap remap, 
> which is irrelevant whether it's cached or not. The QIC cacheline area 
> is the next one below it.

yes, but i assumed that since you had all cached ioremaps before, you 
might wanted it for all of the devices in voyager_cat.c (or at least it 
wouldnt hurt). Btw., the QIC ioremap i changed in my patch too, just in 
case you didnt notice:

quoted text
> > -               qic_addr = (unsigned long)ioremap(qic_addr, 0x400);
> > +               qic_addr = (unsigned long)ioremap_cache(qic_addr, 0x400);

so my patch too should do the trick.

	Ingo
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/