Re: [PATCH] bitops: simplify generic bit finding functions

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Harvey Harrison <harvey.harrison@...>
Cc: Ingo Molnar <mingo@...>, Andrew Morton <akpm@...>, LKML <linux-kernel@...>
Date: Sunday, April 27, 2008 - 4:38 pm

On Sun, 27 Apr 2008, Harvey Harrison wrote:

Well, that's really just a sparse bug/misfeature that didn't matter 
before.

It happens because the warning is done as part of constant expression 
evaluation, but then the expression isn't actually *used*, so when we 
optimize it away - at a later date - it's too late to undo the warning.

I don't rightly know how to fix it. We do want to do the constant 
evaluation early (since all the optimizations that may then make it a 
non-issue depends on constants being constants!), but in order to not 
output the warning we'd have to turn the constant into a "constant with 
warning 'xyz' if used".

Which we have no support for in sparse yet.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] bitops: simplify generic bit finding functions, Harvey Harrison, (Sun Apr 27, 4:19 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Alexander van Heukelum, (Mon Apr 28, 10:32 am)
Re: [PATCH] bitops: simplify generic bit finding functions, Linus Torvalds, (Sun Apr 27, 4:26 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Alexander van Heukelum, (Mon Apr 28, 10:58 am)
Re: [PATCH] bitops: simplify generic bit finding functions, Thomas Gleixner, (Mon Apr 28, 10:04 am)
Re: [PATCH] bitops: simplify generic bit finding functions, Linus Torvalds, (Mon Apr 28, 12:25 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Thomas Gleixner, (Mon Apr 28, 12:47 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Linus Torvalds, (Mon Apr 28, 12:54 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Thomas Gleixner, (Mon Apr 28, 3:26 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Linus Torvalds, (Mon Apr 28, 3:37 pm)
[PATCH] bitops: remove "optimizations", Thomas Gleixner, (Tue Apr 29, 6:01 am)
Re: [PATCH] bitops: remove "optimizations", David Miller, (Tue Apr 29, 6:03 am)
Re: [PATCH] bitops: remove "optimizations", David Miller, (Tue Apr 29, 8:34 am)
Re: [PATCH] bitops: remove "optimizations", Thomas Gleixner, (Tue Apr 29, 12:51 pm)
Re: [PATCH] bitops: remove "optimizations", David Miller, (Tue Apr 29, 6:58 pm)
Re: [PATCH] bitops: remove "optimizations", David Miller, (Tue Apr 29, 7:30 pm)
Re: [PATCH] bitops: remove "optimizations", Ingo Molnar, (Tue Apr 29, 10:20 am)
Re: [PATCH] bitops: remove "optimizations", David Miller, (Tue Apr 29, 6:31 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Alexander van Heukelum, (Mon Apr 28, 11:10 am)
Re: [PATCH] bitops: simplify generic bit finding functions, Thomas Gleixner, (Mon Apr 28, 11:58 am)
Re: [PATCH] bitops: simplify generic bit finding functions, Harvey Harrison, (Sun Apr 27, 4:29 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Linus Torvalds, (Sun Apr 27, 4:38 pm)
Re: [PATCH] bitops: simplify generic bit finding functions, Harvey Harrison, (Sun Apr 27, 4:38 pm)