On Wed, Apr 23, 2008 at 10:56:29AM +0200, Uwe Kleine-König wrote:Hi Uwe, sorry for the delay, I was away for a few days and had an awful lot of work when I came back. About your generic platform driver: I think we've got two choices, both of them are acceptable as far as I'm concerned: 1.) Use the clk API and make your driver depend on it. AFAICS, only ARM and PPC implement it right now. On some platforms, it will probably never be implemented. E.g. x86 doesn't have any clocks that could be controlled that way. It's probably only useful for SoCs. Advantages: People who need it get clk support for free, without having to write much code. Disadvantages: The generic platform driver is not available for all platforms. It might not be easy to implement the dependency in Kconfig in a way acceptable to all maintainers ;-) 2.) Don't use the clk API. I don't think we would lose much. Drivers could implement clk stuff in their board support. You could add some generic function pointers in struct uio_platdata that are called in open/release/probe/remove. That way, any platform specific stuff, including clk, could be handled. Advantages: The generic platform driver is available for all platforms, no need for dependencies in Kconfig. Disadvantages: People who need clk_* must write a lot of code within their board support file. Not nice and clean... I'm ready to accept 1.) or 2.), or even both of them (why can't we have two generic platform drivers?) As you are the author (and probably user) of this driver, please decide, and send a new patch for review. Thanks, Hans --
| Linus Torvalds | Re: LSM conversion to static interface |
| Ingo Molnar | [patch 03/13] syslets: generic kernel bits |
| Ingo Molnar | Re: [PATCH 6/6] sched: disabled rt-bandwidth by default |
| Greg Kroah-Hartman | [PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO |
git: | |
| David Miller | [GIT]: Networking |
| Gregory Haskins | [RFC PATCH 00/17] virtual-bus |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
