login
Header Space

 
 

[PATCH] x86: !x & y typo in mtrr code

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>, LKML <linux-kernel@...>
Date: Sunday, April 27, 2008 - 12:00 am

As written, this can never be true.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
index 353efe4..5d241ce 100644
--- a/arch/x86/kernel/cpu/mtrr/generic.c
+++ b/arch/x86/kernel/cpu/mtrr/generic.c
@@ -90,7 +90,7 @@ u8 mtrr_type_lookup(u64 start, u64 end)
 	 * Look of multiple ranges matching this address and pick type
 	 * as per MTRR precedence
 	 */
-	if (!mtrr_state.enabled & 2) {
+	if (!(mtrr_state.enabled & 2)) {
 		return mtrr_state.def_type;
 	}
 
-- 
1.5.5.1.270.g89765



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] x86: !x & y typo in mtrr code, Harvey Harrison, (Sun Apr 27, 12:00 am)
RE: [PATCH] x86: !x &amp; y typo in mtrr code, Pallipadi, Venkatesh, (Mon Apr 28, 7:16 pm)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Ingo Molnar, (Mon Apr 28, 7:27 am)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Harvey Harrison, (Mon Apr 28, 11:10 am)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Al Viro, (Sun Apr 27, 12:20 am)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Ingo Molnar, (Tue Apr 29, 5:04 pm)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Björn, (Wed Apr 30, 2:46 am)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Ingo Molnar, (Wed Apr 30, 5:32 am)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Björn, (Wed Apr 30, 8:17 am)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Ingo Molnar, (Wed Apr 30, 8:35 am)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Harvey Harrison, (Wed Apr 30, 11:35 am)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Ingo Molnar, (Wed Apr 30, 2:06 pm)
Re: [PATCH] x86: !x &amp; y typo in mtrr code, Thomas Gleixner, (Wed Apr 30, 3:46 am)
speck-geostationary