login
Header Space

 
 

[PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <torvalds@...>, <linux-kernel@...>
Cc: <netdev@...>
Date: Friday, April 25, 2008 - 8:58 pm

This bug was introduced in the 2.6.24 i386/x86_64 tree merge, where
MSI-X vector allocation will eventually fail.  The cause is the new
bit array tracking used vectors is not getting cleared properly on
IRQ destruction on the 32-bit APIC code.

This can be seen easily using the ixgbe 10 GbE driver on multi-core
systems by simply loading and unloading the driver a few times.
Depending on the number of available vectors on the host system, the
MSI-X allocation will eventually fail, and the driver will only be
able to use legacy interrupts.

I am generating the same patch for both stable trees for 2.6.24 and
2.6.25.

Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
---

 arch/x86/kernel/io_apic_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c
index 2e2f420..77798b1 100644
--- a/arch/x86/kernel/io_apic_32.c
+++ b/arch/x86/kernel/io_apic_32.c
@@ -2444,6 +2444,7 @@ void destroy_irq(unsigned int irq)
 	dynamic_irq_cleanup(irq);
 
 	spin_lock_irqsave(&vector_lock, flags);
+	clear_bit(irq_vector[irq], used_vectors);
 	irq_vector[irq] = 0;
 	spin_unlock_irqrestore(&vector_lock, flags);
 }

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage, PJ Waskiewicz, (Fri Apr 25, 8:58 pm)
RE: [PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage, Waskiewicz Jr, Peter P, (Tue Apr 29, 11:07 am)
RE: [PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage, Waskiewicz Jr, Peter P, (Tue Apr 29, 8:16 pm)
Re: [PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage, Thomas Gleixner, (Mon Apr 28, 4:30 pm)
RE: [PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage, Waskiewicz Jr, Peter P, (Mon Apr 28, 4:42 pm)
RE: [PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage, Thomas Gleixner, (Mon Apr 28, 5:16 pm)
RE: [PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage, Waskiewicz Jr, Peter P, (Mon Apr 28, 5:21 pm)
speck-geostationary