Andrew Morton wrote:
quoted text
>> +	memcpy(&early_res[i], &early_res[i + 1],
>> +	       (j - 1 - i) * sizeof(struct early_res));
>>     
>
> nit: memcpy() shouldn't be used for overlapping copies.  It happens to be
> OK (for dst<src) in the kernel implementations.  We hope.
>   

Definitely shouldn't be assumed.  At one point in the distant past I had 
a ppc memcpy which would clobber a destination cacheline before reading 
the source, so source and dest within a cacheline's distance would be 
trouble, regardless of the direction.  Arch-specific code which knows 
about the arch-specific details of memcpy might be safer, I guess, but 
its still fairly brittle.

    J
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/