Home » Mailing list archives » linux-kernel » 2008 » April » 26

Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christoph Hellwig <hch@...>
To: Andi Kleen <andi@...>
Cc: Christoph Hellwig <hch@...>, Denys Vlasenko <vda.linux@...>, David Chinner <dgc@...>, <xfs@...>, Eric Sandeen <sandeen@...>, Adrian Bunk <bunk@...>, <linux-kernel@...>
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
Date: Saturday, April 26, 2008 - 4:23 pm

On Sat, Apr 26, 2008 at 10:26:30PM +0200, Andi Kleen wrote:

The whole STATIC thing is weird to start with..

Yes, it's kinda unexpected and at least I don't particularly liked it.
But the inlining of functions with -funit-at-a-time was such a problem
for the stack useage in XFS that it got added as least horrible bandaid.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen, (Sat Apr 26, 4:02 pm)
Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig, (Sat Apr 26, 4:07 pm)
Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen, (Sat Apr 26, 4:26 pm)
Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig, (Sat Apr 26, 4:23 pm)
Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Nathan Scott, (Sun Apr 27, 8:06 pm)
Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen, (Mon Apr 28, 6:32 am)
Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Nathan Scott, (Mon Apr 28, 7:52 pm)
Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig, (Mon Apr 28, 1:56 am)