login
Header Space

 
 

Re: [RFC git pull] "big box" x86 changes

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: <linux-kernel@...>, Andrew Morton <akpm@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>, Yinghai Lu <yinghai.lu@...>, Yinghai Lu <yhlu.kernel@...>, <jbarnes@...>
Date: Saturday, April 26, 2008 - 3:12 pm

On Sat, 26 Apr 2008, Ingo Molnar wrote:

I'd like to see this sent as perhaps four independent pulls (where 
"independent" doesn't necessarily mean that they don't depend on each 
other and have some ordering, but is more of a "this is the bootup 
changes" vs "these are bootmem-related" etc, if at all possible. 

Quite frankly, from a review standpoint, very few people should need to 
(or want to) review individual commits when there are 50 of them (they 
might only care about the changes that 3 or 4 of them make, but they get 
lost in the noise), but at the same time, if you have a single diffstat 
like this:

	45 files changed, 2071 insertions(+), 362 deletions(-)

then you're also going to have people not able to give good feedback.

In contrast, if you send out an email like this one, but that has the 
combined diff of say 10 commits in one area, and the diff is a couple of 
hundred lines of changes rather than almost 2,500 lines, then you'll 
definitely get people who are able and willing to look at four chunks like 
that.

IOW, they'd be big enough that people hopefully don't start nitpicking 
about some *totally* uninteresting small detail, but small enough that 
people can read it through without losing concentration about a quarter of 
the way in.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC git pull] "big box" x86 changes, Ingo Molnar, (Sat Apr 26, 2:55 pm)
Re: [RFC git pull] "big box" x86 changes, Andi Kleen, (Sat Apr 26, 6:17 pm)
Re: [RFC git pull] "big box" x86 changes, Yinghai Lu, (Sat Apr 26, 11:14 pm)
Re: [RFC git pull] "big box" x86 changes II, Andi Kleen, (Sun Apr 27, 4:32 am)
Re: [RFC git pull] "big box" x86 changes, Andi Kleen, (Sun Apr 27, 4:30 am)
Re: [RFC git pull] "big box" x86 changes, Linus Torvalds, (Sat Apr 26, 3:12 pm)
[git pull] "big box" x86 changes, PCI, Ingo Molnar, (Sat Apr 26, 5:55 pm)
Re: [git pull] "big box" x86 changes, PCI, Jesse Barnes, (Mon Apr 28, 4:34 pm)
Re: [git pull] "big box" x86 changes, PCI, Yinghai Lu, (Mon Apr 28, 6:53 pm)
Re: [git pull] "big box" x86 changes, PCI, Jesse Barnes, (Sun Apr 27, 12:30 pm)
Re: [git pull] "big box" x86 changes, PCI, Ingo Molnar, (Mon Apr 28, 11:38 am)
[RFC git pull] "big box" x86 changes, GART, Ingo Molnar, (Sat Apr 26, 4:24 pm)
Re: [RFC git pull] "big box" x86 changes, GART, Ingo Molnar, (Sat Apr 26, 4:26 pm)
[git pull] "big box" x86 changes, boot protocol, Ingo Molnar, (Sat Apr 26, 3:54 pm)
Re: [git pull] "big box" x86 changes, boot protocol, Ian Campbell, (Sun Apr 27, 7:21 am)
Re: [git pull] "big box" x86 changes, boot protocol, Ingo Molnar, (Mon Apr 28, 11:27 am)
Re: [git pull] "big box" x86 changes, boot protocol, H. Peter Anvin, (Sun Apr 27, 3:29 pm)
Re: [git pull] "big box" x86 changes, boot protocol, Andrew Morton, (Sat Apr 26, 4:39 pm)
Re: [git pull] "big box" x86 changes, boot protocol, Jeremy Fitzhardinge, (Sat Apr 26, 7:37 pm)
Re: [git pull] "big box" x86 changes, boot protocol, Adrian Bunk, (Sat Apr 26, 5:06 pm)
Re: [git pull] "big box" x86 changes, boot protocol, Linus Torvalds, (Sat Apr 26, 5:11 pm)
Re: [git pull] "big box" x86 changes, boot protocol, Ingo Molnar, (Sat Apr 26, 5:17 pm)
Re: [git pull] "big box" x86 changes, boot protocol, H. Peter Anvin, (Sat Apr 26, 5:10 pm)
[git pull] "big box" x86 changes, bootmem/sparsemem, Ingo Molnar, (Sat Apr 26, 3:41 pm)
Re: [git pull] "big box" x86 changes, bootmem/sparsemem, Johannes Weiner, (Sun Apr 27, 6:48 pm)
Re: [git pull] "big box" x86 changes, bootmem/sparsemem, Johannes Weiner, (Mon Apr 28, 12:58 pm)
Re: [git pull] "big box" x86 changes, bootmem/sparsemem, Johannes Weiner, (Sun Apr 27, 8:19 pm)
[patch] mm: node-setup agnostic free_bootmem(), Ingo Molnar, (Sun Apr 27, 8:40 pm)
Re: [patch] mm: node-setup agnostic free_bootmem(), Johannes Weiner, (Mon Apr 28, 12:49 pm)
Re: [patch] mm: node-setup agnostic free_bootmem(), Ingo Molnar, (Tue Apr 29, 10:25 am)
Re: [patch] mm: node-setup agnostic free_bootmem(), Johannes Weiner, (Wed Apr 30, 6:52 am)
Re: [patch] mm: node-setup agnostic free_bootmem(), Yinghai Lu, (Sun Apr 27, 9:48 pm)
Re: [patch] mm: node-setup agnostic free_bootmem(), Johannes Weiner, (Mon Apr 28, 12:54 pm)
Re: [patch] mm: node-setup agnostic free_bootmem(), Yinghai Lu, (Mon Apr 28, 3:11 pm)
Re: [patch] mm: node-setup agnostic free_bootmem(), Yinghai Lu, (Mon Apr 28, 3:55 pm)
Re: [patch] mm: node-setup agnostic free_bootmem(), Johannes Weiner, (Wed Apr 30, 6:50 am)
Re: [patch] mm: node-setup agnostic free_bootmem(), Yinghai Lu, (Wed Apr 30, 12:22 pm)
Re: [patch] mm: node-setup agnostic free_bootmem(), Johannes Weiner, (Wed Apr 30, 1:52 pm)
Re: [patch] mm: node-setup agnostic free_bootmem(), Yinghai Lu, (Wed Apr 30, 4:30 pm)
Re: [git pull] "big box" x86 changes, bootmem/sparsemem, Linus Torvalds, (Sat Apr 26, 3:52 pm)
Re: [RFC git pull] "big box" x86 changes, Stefan Richter, (Sat Apr 26, 3:05 pm)
Re: [RFC git pull] "big box" x86 changes, Ingo Molnar, (Sat Apr 26, 3:21 pm)
speck-geostationary