Home » Mailing list archives » linux-kernel » 2008 » April » 26

Re: [git pull] x86 PAT changes

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Molnar <mingo@...>
To: Linus Torvalds <torvalds@...>
Cc: <linux-kernel@...>, Andrew Morton <akpm@...>, H. Peter Anvin <hpa@...>, Thomas Gleixner <tglx@...>
Subject: Re: [git pull] x86 PAT changes
Date: Saturday, April 26, 2008 - 5:57 am

* Linus Torvalds <torvalds@linux-foundation.org> wrote:


yeah - i already toned it down to KERN_INFO once in commit 28eb559b5 - 
but it should be pr_debug() instead. The idea in pat.c is to only print 
out if it's a material condition that the user should know about. I've 
queued up the patch below.

	Ingo

-------->
Subject: x86 PAT: tone down debugging messages
From: Ingo Molnar <mingo@elte.hu>
Date: Sat Apr 26 11:40:31 CEST 2008

Linus reported these excessive debug printouts:


turn that into a pr_debug().

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/mm/pat.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-x86.q/arch/x86/mm/pat.c
===================================================================
--- linux-x86.q.orig/arch/x86/mm/pat.c
+++ linux-x86.q/arch/x86/mm/pat.c
@@ -334,7 +334,7 @@ int reserve_memtype(u64 start, u64 end, 
 				break;
 			}
 
-			printk("Overlap at 0x%Lx-0x%Lx\n",
+			pr_debug("Overlap at 0x%Lx-0x%Lx\n",
 			       saved_ptr->start, saved_ptr->end);
 			/* No conflict. Go ahead and add this new entry */
 			list_add(&new_entry->nd, saved_ptr->nd.prev);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[git pull] x86 PAT changes, Ingo Molnar, (Thu Apr 24, 6:56 pm)
Re: [git pull] x86 PAT changes, Gabriel C, (Sat Apr 26, 9:40 am)
Re: [git pull] x86 PAT changes, Ingo Molnar, (Sat Apr 26, 10:42 am)
Re: [git pull] x86 PAT changes, Gabriel C, (Sat Apr 26, 11:37 am)
Re: [git pull] x86 PAT changes, Ingo Molnar, (Sat Apr 26, 11:41 am)
Re: [git pull] x86 PAT changes, Linus Torvalds, (Sat Apr 26, 12:43 pm)
Re: [git pull] x86 PAT changes, Linus Torvalds, (Fri Apr 25, 7:43 pm)
Re: [git pull] x86 PAT changes, Ingo Molnar, (Sat Apr 26, 5:57 am)
Re: [git pull] x86 PAT changes, H. Peter Anvin, (Fri Apr 25, 8:06 pm)
Re: [git pull] x86 PAT changes, Linus Torvalds, (Fri Apr 25, 9:12 pm)
Re: [git pull] x86 PAT changes, Ingo Molnar, (Sat Apr 26, 4:56 am)
RE: [git pull] x86 PAT changes, Pallipadi, Venkatesh, (Sat Apr 26, 12:54 pm)
RE: [git pull] x86 PAT changes, Linus Torvalds, (Sat Apr 26, 1:15 pm)
Re: [git pull] x86 PAT changes, Venki Pallipadi, (Sat Apr 26, 2:32 pm)
[patch] x86, PAT: disable /dev/mem mmap RAM with PAT, Ingo Molnar, (Sat Apr 26, 3:07 pm)