login
Header Space

 
 

Re: Announce: Semaphore-Removal tree

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Matthew Wilcox <matthew@...>
Cc: <linux-kernel@...>, Stephen Rothwell <sfr@...>
Date: Friday, April 25, 2008 - 4:38 pm

On Fri, 2008-04-25 at 11:00 -0600, Matthew Wilcox wrote:

I was reviewing your patches, and I don't like the semaphore to spinlock
changes.. There's no reason to start adding spinlocks, unless it's
really performance sensitive which none of those places are.. 

Also the ps3-gelic changes for instance is three locks in one patch. It
should be one lock per patch .. I have a broken out conversion for gelic
which I was going to submit in my next round ..

There's also a number of other people doing these , so you might want to
hold off on doing more unless you know they aren't already completed ..

Daniel

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Announce: Semaphore-Removal tree, Matthew Wilcox, (Fri Apr 25, 1:00 pm)
Re: Announce: Semaphore-Removal tree, David Chinner, (Mon Apr 28, 1:10 am)
Re: Announce: Semaphore-Removal tree, Matthew Wilcox, (Mon Apr 28, 8:20 am)
Re: Announce: Semaphore-Removal tree, David Chinner, (Mon Apr 28, 8:09 pm)
Re: Announce: Semaphore-Removal tree, Matthew Wilcox, (Wed Apr 30, 6:06 am)
Re: Announce: Semaphore-Removal tree, David Chinner, (Wed Apr 30, 7:01 am)
Re: Announce: Semaphore-Removal tree, Matthew Wilcox, (Mon Apr 28, 10:35 pm)
Re: Announce: Semaphore-Removal tree, David Chinner, (Mon Apr 28, 11:56 pm)
Re: Announce: Semaphore-Removal tree, Matthew Wilcox, (Wed Apr 30, 6:21 am)
Re: Announce: Semaphore-Removal tree, Stephen Rothwell, (Sat Apr 26, 9:54 am)
Re: Announce: Semaphore-Removal tree, Matthew Wilcox, (Sat Apr 26, 11:59 am)
Re: Announce: Semaphore-Removal tree, Stephen Rothwell, (Sat Apr 26, 12:43 pm)
Re: Announce: Semaphore-Removal tree, Daniel Walker, (Fri Apr 25, 4:38 pm)
Re: Announce: Semaphore-Removal tree, Christoph Hellwig, (Fri Apr 25, 5:12 pm)
Re: Announce: Semaphore-Removal tree, Daniel Walker, (Fri Apr 25, 5:22 pm)
Re: Announce: Semaphore-Removal tree, Christoph Hellwig, (Sat Apr 26, 5:30 am)
Re: Announce: Semaphore-Removal tree, Peter Zijlstra, (Sat Apr 26, 9:39 am)
Re: Announce: Semaphore-Removal tree, Christoph Hellwig, (Sat Apr 26, 9:44 am)
Re: Announce: Semaphore-Removal tree, David Chinner, (Mon Apr 28, 12:59 am)
Re: Announce: Semaphore-Removal tree, Peter Zijlstra, (Sat Apr 26, 10:04 am)
Re: Announce: Semaphore-Removal tree, Daniel Walker, (Fri Apr 25, 4:24 pm)
speck-geostationary