On Fri, 25 Apr 2008, Ingo Molnar wrote:No. That whole code sequence is total and utter crap. It needs to be rewritten. It first does a BUG_ON() if it's not naturally aligned (because that wouldn't be atomic), and then it has code for page crossing! What a TOTAL PIECE OF SH*T! Hint: - if it's naturally aligned, it couldn't be page crossing ANYWAY - and if it was a page-crosser, it sure as hell couldn't be atomic! The code is just crap, crap, crap. It needs to be rewritten from scratch. I'll have a patch soonish. Linus --
| David Miller | Re: Slow DOWN, please!!! |
| debian developer | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Roland Dreier | Re: Integration of SCST in the mainstream Linux kernel |
| Ingo Molnar | Re: containers (was Re: -mm merge plans for 2.6.23) |
git: | |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Josip Rodin | bnx2_poll panicking kernel |
| David Miller | [GIT]: Networking |
| Gerrit Renker | [PATCH 13/37] dccp: Deprecate Ack Ratio sysctl |
