login
Header Space

 
 

Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Miller <davem@...>
Cc: <jeff@...>, <paulkf@...>, <jchapman@...>, <alan@...>, <akpm@...>, <linux-kernel@...>, <netdev@...>
Date: Thursday, April 24, 2008 - 4:46 pm

David Miller <davem@davemloft.net> writes:


It's not about extensions, syncppp is just unmaintainable. It's
implementation of two protocols - Cisco HDLC and (sync) PPP intermixed
together.

What would be needed is a) splitting them into two files (including
protocol selection in drivers - somehow), b) replacing existing
broken syncppp state machines distributed all over the place with a
single sane state machine, c) perhaps adding IPv6, people want it,
d) packet flow from hw drivers would need to be upgraded as well
(*_type_trans() and fast path for IP/IPv6 and perhaps IPX, though
I don't know anyone ever using IPX with sync PPP).

I guess then you'd get generic HDLC.

I think it's easier to a) simply remove syncppp.c, b) apply my patch
with new PPP, c) blindly port the old drivers to generic HDLC,
d) hope for the best, with a bit of luck nobody would notice.

Alternative c) simply remove the old drivers (d) unchanged).

I don't want the breakage resulting from either action thus I think
syncppp.c should stay there (basically unchanged, though we could
at last remove those variables used only by the original FreeBSD
code in 1994).

If the new implementation is my patch or if it uses generic PPP is
debatable. I think simplicity is a good thing, the interface to
generic PPP would be bigger than the whole sync-only PPP. But I'm not
against using generic PPP, it's (AFAICS) clean and *working* and
*maintained* (and I'm not worried about backward compatibility and
certainly not about users' visions).
-- 
Krzysztof Halasa
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Wed Mar 12, 2:21 pm)
[PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Fri Mar 14, 10:20 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Tue Mar 25, 10:39 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Fri Apr 11, 5:35 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Andrew Morton, (Sat Apr 12, 1:14 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Sat Apr 12, 4:10 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Jeff Garzik, (Sat Apr 12, 4:50 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Sat Apr 12, 3:25 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Sat Apr 12, 4:19 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Fri Apr 18, 11:58 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Fri Apr 18, 6:32 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Mon Apr 21, 11:30 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, James Chapman, (Mon Apr 21, 3:31 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Tue Apr 22, 3:06 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Paul Fulghum, (Tue Apr 22, 5:46 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Tue Apr 22, 6:02 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Paul Fulghum, (Tue Apr 22, 7:52 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Jeff Garzik, (Tue Apr 22, 4:50 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, James Chapman, (Tue Apr 22, 6:23 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Tue Apr 22, 6:51 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Tue Apr 22, 6:05 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Wed Apr 23, 1:02 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Wed Apr 23, 6:49 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Wed Apr 23, 8:48 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Wed Apr 23, 9:08 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Thu Apr 24, 9:12 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Thu Apr 24, 9:30 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Thu Apr 24, 9:39 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Thu Apr 24, 9:55 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Thu Apr 24, 4:46 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Mon May 12, 6:32 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Wed May 14, 12:17 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Wed May 14, 8:45 am)
[PATCH] WAN: protect HDLC proto list while insmod/rmmod, Krzysztof Halasa, (Mon May 19, 1:00 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Fri Apr 25, 7:10 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Thu Apr 24, 4:50 pm)
RE: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Waskiewicz Jr, Peter P, (Mon Apr 14, 3:16 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Mon Apr 14, 5:09 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Jeff Garzik, (Tue Mar 25, 10:55 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Tue Mar 25, 11:50 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Wed Mar 26, 7:05 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, David Miller, (Tue Mar 25, 7:14 pm)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Wed Mar 26, 11:01 am)
Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC, Jeff Garzik, (Sat Apr 12, 5:12 am)
[PATCH] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Wed Mar 12, 2:30 pm)
Re: [PATCH] Re: WAN: new PPP code for generic HDLC, Jan Engelhardt, (Wed Mar 12, 3:38 pm)
Re: [PATCH] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Wed Mar 12, 4:10 pm)
Re: [PATCH] Re: WAN: new PPP code for generic HDLC, Jan Engelhardt, (Wed Mar 12, 6:12 pm)
Re: [PATCH] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Fri Mar 14, 10:16 am)
Re: [PATCH] Re: WAN: new PPP code for generic HDLC, Stephen Hemminger, (Wed Mar 12, 2:52 pm)
Re: [PATCH] Re: WAN: new PPP code for generic HDLC, Krzysztof Halasa, (Wed Mar 12, 3:25 pm)
speck-geostationary