On Thu, Apr 24, 2008 at 12:57:08PM +0000, Michael Abbott wrote:
quoted text
> From: Michael Abbott <michael.abbott@diamond.ac.uk>
>
> [PATCH] DM9000: Reimplement 2-resource device specification
>
> In commit 1a5f1c4ff80f522555d78d4dd0109f18395c6d83 a change was made to
> the handling of the resources passed the DM9000 device.  Unfortunately,
> if only two resources are passed (the read and write register in the same
> area) the pointer db->irq_res ends up being used without being initialised.
>
> This patch tidies this up a little.  Only one architecture class,
> blackfin, uses two resource specification, so it may be better to enforce
> three resource specification as before by simply removing the 0 and 2
> resource branches from dm9000_probe.

I think then we should probably make the driver simpler and remove the
special case for the two resources... any small saving of using just
two resources is probably cancelled out by the extra code needed.

quoted text
> +#define res_size(_r) (((_r)->end - (_r)->start) + 1)
> +

I'd like to see something like this as an inline function in the
relevant header, and some patches to get other users to find it.

quoted text
> -
>  		if (pdata->outblk != NULL)
>  			db->outblk = pdata->outblk;
> -
>  		if (pdata->dumpblk != NULL)
>  			db->dumpblk = pdata->dumpblk;

I'd rather not see spacing changes done, especially as I don't like
to see lots of code cramped together. 

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/