On Thu, 24 Apr 2008, Ben Dooks wrote:
quoted text
> On Thu, Apr 24, 2008 at 10:13:09AM +0000, Michael Abbott wrote:
>> From: Michael Abbott <michael.abbott@diamond.ac.uk>
>>
>> Colibri: Fix support for DM9000 ethernet device.
>> diff --git a/arch/arm/mach-pxa/colibri.c b/arch/arm/mach-pxa/colibri.c
>> --- a/arch/arm/mach-pxa/colibri.c
>> +++ b/arch/arm/mach-pxa/colibri.c
>> @@ -118,7 +118,7 @@ static void __init colibri_init(void)
>>  	/* DM9000 LAN */
>>  	pxa_gpio_mode(GPIO78_nCS_2_MD);
>>  	pxa_gpio_mode(GPIO_DM9000 | GPIO_IN);
>> -	set_irq_type(COLIBRI_ETH_IRQ, IRQT_FALLING);
>> +	set_irq_type(COLIBRI_ETH_IRQ, IRQT_RISING);
>
> The set_irq_type() call here should be removed.

I can confirm that Ben is right, and that the set_irq_type call can be 
removed.

What is the procedure here?  Do I submit a new patch to supersede the old 
one?
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/