Thanks to Julia Lawall for help with spatch, Joe Perches, Segher Boessenkool and others for catching errors. spatch can be found at http://www.emn.fr/x-info/coccinelle/ The script used and others can be found at http://kernelnewbies.org/RoelKluin Now it's time for me to get some sleep Roel --

SYSVIPC is a pretty crucial feature that I doubt very much if anyone except embedded people should even consider disabling - it simply breaks too much software for a Linux box to really be useful without it, for most purposes. For that reason I find it quite odd that the feature defaults to 'No' currently. I really cannot see any reason why we wouldn't want this to default to 'Yes', so this patch changes the default by adding 'default y' to Kconfig. Signed-off-by: Jesper Juhl <jesper.juh...

Commit b716bb91 ("iwlwifi: Cancel scanning upon association") moved the test of priv->vif in iwl{3945,4964}_mac_config_interface() outside of where priv->mutex is held, but still tries to do mutex_unlock() on return. This is clearly wrong and triggers a nasty lockdep warning when this codepath is triggered. Fix this by removing the mutex_unlock(). Signed-off-by: Roland Dreier <rolandd@cisco.com> --- Assuming the original b716bb91 commit is correct, this is probably the right fix. Bu...

any reason why "make cloneconfig" never made it into mainline? many people are quite used to it and every time i build vanilla kernel i step into that trap "oh - that`s a suse`ism" make cloneconfig exists since /proc/config.gz - but while that one went into mainline, cloneconfig never did. anyone know the reason for that ? i wished, distros kernels were more similar to vanilla kernels - so what about making them more similar ? [ message continues ]

From: Jesper Juhl <jesper.juhl@gmail.com> This patch reduces the number of sequential pointer derefs in scsi_error ( drivers/scsi/scsi_error.c ). The bennefits of this are: - makes the code easier to read. Lots of sequential derefs of the same pointers are not easy on the eye. - makes the size of the source file 55 bytes smaller. - makes the size of the object file 48 bytes smaller. - theoretically at least, just dereferencing the pointers once can allow the compiler to gener...

Subject: sched: aggregate_group_shares no loop Remove the chance of getting trapped in the loop. Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> --- kernel/sched.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: linux-2.6-2/kernel/sched.c =================================================================== --- linux-2.6-2.orig/kernel/sched.c +++ linux-2.6-2/kernel/sched.c @@ -1713,7 +1713,6 @@ void aggregate_group_shares(struct task_ unsigned long shares ...

dev->irq is unsigned, platform_get_irq() may return signed unnoticed Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c index ba6bd03..a637910 100644 --- a/drivers/net/arm/am79c961a.c +++ b/drivers/net/arm/am79c961a.c @@ -693,11 +693,15 @@ static int __init am79c961_probe(struct platform_device *pdev) * done by the ether bootp loader. */ dev->base_addr = res->start; - dev->irq = platform_get_irq(pdev,...

I found out that iwconfig wlan0 ap auto (which according to the man page should reassociate with the strongest AP) does nothing at all. It seems that once associated with AP, the mac or iwl4965 driver (do not know which one) is unable to associate with a different AP. -- Lukáš Hejtmánek --

asic->irq_nr is unsigned. platform_get_irq() may return signed unnoticed Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c index f6f2d96..95f7b0c 100644 --- a/drivers/mfd/asic3.c +++ b/drivers/mfd/asic3.c @@ -302,7 +302,7 @@ static int asic3_irq_probe(struct platform_device *pdev) unsigned int irq, irq_base; asic->irq_nr = platform_get_irq(pdev, 0); - if (asic->irq_nr < 0) + if (asic->irq_nr == -ENXIO) return ...

Thanks to Joe Perches for catching an error in my previous --- asic->irq_nr is unsigned. platform_get_irq() may return signed unnoticed Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c index f6f2d96..abd7ffc 100644 --- a/drivers/mfd/asic3.c +++ b/drivers/mfd/asic3.c @@ -300,10 +300,13 @@ static int asic3_irq_probe(struct platform_device *pdev) struct asic3 *asic = platform_get_drvdata(pdev); unsigned long clksel = 0; unsigne...

ifd->offset is unsigned. gigaset_isowbuf_getbytes() may return signed unnoticed Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c index 5255b5e..c97479b 100644 --- a/drivers/isdn/gigaset/bas-gigaset.c +++ b/drivers/isdn/gigaset/bas-gigaset.c @@ -1050,9 +1050,9 @@ static int submit_iso_write_urb(struct isow_urbctx_t *ucx) } /* retrieve block of data to send */ - ifd->offset = gigaset_isowbuf_...

mpc83xx_spi->irq is unsigned, so the test fails Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c index be15a62..033fd51 100644 --- a/drivers/spi/spi_mpc83xx.c +++ b/drivers/spi/spi_mpc83xx.c @@ -454,12 +454,12 @@ static int __init mpc83xx_spi_probe(struct platform_device *dev) goto put_master; } - mpc83xx_spi->irq = platform_get_irq(dev, 0); - - if (mpc83xx_spi->irq < 0) { - ret = -ENXIO; + ret = pl...

Due to debug hooks in the kernel that can change the way smp_processor_id works, use raw_smp_processor_id in mcount called functions (namely ftrace_record_ip). Currently we annotate most debug functions from calling mcount, but we should not rely on that to prevent kernel lockups. This patch uses the raw_smp_processor_id to prevent a recusive crash that can happen if a debug hook in smp_processor_id calls mcount. Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- kernel/trace/ftrac...

similarly, --- xilinx_spi->irq is unsigned, so the test fails Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c index cf6aef3..613db82 100644 --- a/drivers/spi/xilinx_spi.c +++ b/drivers/spi/xilinx_spi.c @@ -353,11 +353,12 @@ static int __init xilinx_spi_probe(struct platform_device *dev) goto put_master; } - xspi->irq = platform_get_irq(dev, 0); - if (xspi->irq < 0) { - ret = -ENXIO; + ret = platform...

This patch allows softlockup detection to be disabled by specifying a boottime parameter. Signed-off-by: Dimitri Sivanich <sivanich@sgi.com> Index: linux/kernel/softlockup.c =================================================================== --- linux.orig/kernel/softlockup.c 2008-04-23 13:50:06.000000000 -0500 +++ linux/kernel/softlockup.c 2008-04-23 14:39:36.267398531 -0500 @@ -24,6 +24,7 @@ static DEFINE_PER_CPU(unsigned long, tou static DEFINE_PER_CPU(unsigned long, print_timestamp); ...

Oops, my bad, I missed the other 'nosoftlockup'. --

previously in this function: u32 index = (dwrq->flags & IW_ENCODE_INDEX) - 1; index is unsigned, so if -1, the original test (below) didn't work. Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/net/wireless/prism54/isl_ioctl.c b/drivers/net/wireless/prism54/isl_ioctl.c index e5b3c28..5b375b2 100644 --- a/drivers/net/wireless/prism54/isl_ioctl.c +++ b/drivers/net/wireless/prism54/isl_ioctl.c @@ -1186,7 +1186,7 @@ prism54_get_encode(struct net_device *ndev, st...

The block I/O + elevator + I/O scheduler code spends a lot of time trying to merge I/Os -- rightfully so under "normal" circumstances. However, if one were to know that the incoming I/O stream was /very/ random in nature, the cycles are wasted. (This can be the case, for example, during OLTP-type runs.) This patch stream adds a per-request_queue tunable that (when set) disables merge attempts, thus freeing up a non-trivial amount of CPU cycles. I'll be doing some more benchmarking, but this is a ...

[Empty message]

Hello, I've put together an automatic system for applying kernel security patches to the Linux kernel without rebooting it, and I wanted to share this system with the community in case others find it useful or interesting. Here's the summary: The system takes as input a kernel security patch (which can be a unified diff taken directly from Linus' GIT tree) and the source code corresponding to the running kernel, and it automatically creates a set of kernel modules to perform the update. Th...

This untested patch is supposed to fix DMAing on some VIA boards. Currently the DMA subsystem returns an error, if the driver does tell that it supports a 64bit DMA mask. So the driver probing would fail in that case. This happens for some b43 cards with 64bit DMA engines on VIA boards. Instead of failing the dma_supported() check, simply strip off the high 32bits. Signed-off-by: Michael Buesch <mb@bu3sch.de> --- This is not tested, due to the lack of hardware. Index: wireless-test...

pll->post_divider is unsigned, so the test fails Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/video/aty/aty128fb.c b/drivers/video/aty/aty128fb.c index cbd3308..5617259 100644 --- a/drivers/video/aty/aty128fb.c +++ b/drivers/video/aty/aty128fb.c @@ -1339,8 +1339,6 @@ static int aty128_var_to_pll(u32 period_in_ps, struct aty128_pll *pll, if (vclk * 12 < c.ppll_min) vclk = c.ppll_min/12; - pll->post_divider = -1; - /* now, find an acceptable divi...

Fix build failure on other platforms because this driver includes registers that do not exist on other platforms. Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com> --- a/drivers/mfd/Kconfig 2008-04-23 11:16:06.000000000 -0700 +++ b/drivers/mfd/Kconfig 2008-04-23 11:16:52.000000000 -0700 @@ -32,6 +32,7 @@ config HTC_EGPIO config HTC_PASIC3 tristate "HTC PASIC3 LED/DS1WM chip support" + depends on ARCH_PXA help This core driver provides register access for the LED...

From: Eric Paris <eparis@redhat.com> This patch changes capability.h to fix whitespace and syntax issues. Things that are fixed may include (does not not have to include) whitespace at end of lines spaces followed by tabs spaces used instead of tabs spacing around parenthesis location of { around structs and else clauses location of * in pointer declarations removal of initialization of static data to keep it in the right section useless {} in if statemetns useless checking for NULL be...

From: Eric Paris <eparis@redhat.com> This patch changes kernel/capability.c to fix whitespace and syntax issues. Things that are fixed may include (does not not have to include) whitespace at end of lines spaces followed by tabs spaces used instead of tabs spacing around parenthesis location of { around structs and else clauses location of * in pointer declarations removal of initialization of static data to keep it in the right section useless {} in if statemetns useless checking for ...