Re: [PATCH] PCI Express ASPM support should default to 'No'

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Jesse Barnes

Subject: Re: [PATCH] PCI Express ASPM support should default to 'No'

Date: Wednesday, April 23, 2008 - 3:46 pm

On Tuesday, April 22, 2008 6:05 pm Shaohua Li wrote:
quoted text> On Tue, 2008-04-22 at 17:12 -0700, Jesse Barnes wrote:
> > On Tuesday, April 22, 2008 3:28 pm Jesper Juhl wrote:
> > > Running 'make oldconfig' I just noticed that PCIEASPM defaults to
> > > 'y' in Kconfig even though the feature is both experimental and the
> > > help text recommends that if you are unsure you say 'n'.
> > > It seems to me that this really should default to 'n', not 'y' at the
> > > moment.
> > > The following patch makes that change. Please consider applying.
> >
> > Seem reasonable, Shaohua?  Please cc linux-pci on PCI patches
> > though...
>
> Ok, I'm fine with the patch. Though by default, the policy is to use
> BIOS setting, that is if BIOS disables ASPM, we don't enable it too.

Ok, pushed.  Thanks Jesper & Shaohua.

Jesse
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] PCI Express ASPM support should default to 'No', Jesper Juhl, (Tue Apr 22, 3:28 pm)

Re: [PATCH] PCI Express ASPM support should default to 'No', Jesse Barnes, (Tue Apr 22, 5:12 pm)

Re: [PATCH] PCI Express ASPM support should default to 'No', Shaohua Li, (Tue Apr 22, 6:05 pm)

Re: [PATCH] PCI Express ASPM support should default to 'No', Jesse Barnes, (Wed Apr 23, 3:46 pm)

Re: [PATCH] PCI Express ASPM support should default to 'No', Andi Kleen, (Thu Apr 24, 12:49 am)

Re: [PATCH] PCI Express ASPM support should default to 'No', Shaohua Li, (Thu Apr 24, 1:02 am)

Re: [PATCH] PCI Express ASPM support should default to 'No', Jesse Barnes, (Thu Apr 24, 8:33 am)

Re: [PATCH] PCI Express ASPM support should default to 'No', Shaohua Li, (Thu Apr 24, 6:16 pm)

Re: [PATCH] PCI Express ASPM support should default to 'No', Jesper Juhl, (Sun Apr 27, 1:01 pm)

Navigation

Popular discussions


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe	[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann	Re: finding your own dead "CONFIG_" variables
Mark Brown	[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds	[LGUEST] Look in object dir for .config
git:
Brian Downing	Re: Git in a Nutshell guide
John Benes	Re: master has some toys
Matthias Lederhofer	[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian	[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano	Re: Rss produced by git is not valid xml?
git-commits-head:
Linux Kernel Mailing List	iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List	ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List	ixgbe: fix several counter register errata
Linux Kernel Mailing List	b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List	9p: block-based virtio client
linux-netdev:
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
David Daney	[PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI.
Wolfgang Grandegger	[PATCH net-next v4 1/3] can: mscan: fix improper return if dlc < 8 in start_xmi...
Amit Kumar Salecha	[PATCHv3 NEXT 2/2] NET: Add Qlogic ethernet driver for CNA devices
openbsd-misc:
Theo de Raadt	Re: Old IPSEC bug
Tomáš Bodžár	Problem with vpnc connection - check group password !
Insan Praja SW	Mandoc Compiling Error
Carl Roberso	Re: Cannot change MTU of carp interface?
Richard Daemon	Re: booting openbsd on eee without cd-rom

Colocation donated by:

Syndicate