Home » Mailing list archives » linux-kernel » 2008 » April » 23

[RFC][PATCH 2/2] sched: aggregate_group_shares no loop

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Peter Zijlstra <peterz@...>
To: Ingo Molnar <mingo@...>
Cc: Dhaval Giani <dhaval@...>, Srivatsa Vaddagiri <vatsa@...>, Dmitry Adamushko <dmitry.adamushko@...>, linux-kernel <linux-kernel@...>, David Miller <davem@...>, Mike Galbraith <efault@...>
Subject: [RFC][PATCH 2/2] sched: aggregate_group_shares no loop
Date: Wednesday, April 23, 2008 - 6:09 pm

Subject: sched: aggregate_group_shares no loop

Remove the chance of getting trapped in the loop.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 kernel/sched.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux-2.6-2/kernel/sched.c
===================================================================
--- linux-2.6-2.orig/kernel/sched.c
+++ linux-2.6-2/kernel/sched.c
@@ -1713,7 +1713,6 @@ void aggregate_group_shares(struct task_
 	unsigned long shares = 0;
 	int i;
 
-again:
 	for_each_cpu_mask(i, sd->span)
 		shares += tg->cfs_rq[i]->shares;
 
@@ -1723,7 +1722,9 @@ again:
 	 */
 	if (unlikely(!shares && aggregate(tg, sd)->rq_weight)) {
 		__aggregate_redistribute_shares(tg);
-		goto again;
+
+		for_each_cpu_mask(i, sd->span)
+			shares += tg->cfs_rq[i]->shares;
 	}
 
 	aggregate(tg, sd)->shares = shares;


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC][PATCH 1/2] sched: higher granularity load on 64bit sys..., Peter Zijlstra, (Wed Apr 23, 6:07 pm)
Re: [RFC][PATCH 1/2] sched: higher granularity load on 64bit..., David Miller, (Wed Apr 23, 8:27 pm)
Re: [RFC][PATCH 1/2] sched: higher granularity load on 64bit..., Peter Zijlstra, (Thu Apr 24, 2:47 am)
Re: [RFC][PATCH 1/2] sched: higher granularity load on 64bit..., Dhaval Giani, (Wed Apr 23, 9:58 pm)
Re: [RFC][PATCH 1/2] sched: higher granularity load on 64bit..., David Miller, (Wed Apr 23, 10:13 pm)
[RFC][PATCH 2/2] sched: aggregate_group_shares no loop, Peter Zijlstra, (Wed Apr 23, 6:09 pm)