Home » Mailing list archives » linux-kernel » 2008 » April » 23

[PATCH] serial: s3c2410: platform_get_irq() may return signed unnoticed

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin <12o3l@...>
To: <ben-linux@...>, Linux-arm <linux-arm-kernel@...>, lkml <linux-kernel@...>
Subject: [PATCH] serial: s3c2410: platform_get_irq() may return signed unnoticed
Date: Wednesday, April 23, 2008 - 5:59 pm

dev->irq is unsigned, platform_get_irq() may return signed unnoticed

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/serial/s3c2410.c b/drivers/serial/s3c2410.c
index 4ffa258..da5a02c 100644
--- a/drivers/serial/s3c2410.c
+++ b/drivers/serial/s3c2410.c
@@ -1022,6 +1022,7 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
 	struct uart_port *port = &ourport->port;
 	struct s3c2410_uartcfg *cfg;
 	struct resource *res;
+	int ret;
 
 	dbg("s3c24xx_serial_init_port: port=%p, platdev=%p\n", port, platdev);
 
@@ -1064,9 +1065,11 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
 
 	port->mapbase	= res->start;
 	port->membase	= S3C24XX_VA_UART + (res->start - S3C24XX_PA_UART);
-	port->irq	= platform_get_irq(platdev, 0);
-	if (port->irq < 0)
+	ret = platform_get_irq(platdev, 0);
+	if (ret < 0)
 		port->irq = 0;
+	else
+		port->irq = ret;
 
 	ourport->clk	= clk_get(&platdev->dev, "uart");
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] serial: s3c2410: platform_get_irq() may return signe..., Roel Kluin, (Wed Apr 23, 5:59 pm)
Re: [PATCH] serial: s3c2410: platform_get_irq() may return s..., Alan Cox, (Thu Apr 24, 6:18 am)
Re: [PATCH] serial: s3c2410: platform_get_irq() may return s..., Alan Cox, (Thu Apr 24, 6:17 am)
Re: [PATCH] serial: s3c2410: platform_get_irq() may return s..., Uwe , (Thu Apr 24, 2:12 am)