Home » Mailing list archives » linux-kernel » 2008 » April » 23

[PATCH 2/2] ARM: ax88796: platform_get_irq() may return signed unnoticed

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin
Subject: [PATCH 2/2] ARM: ax88796: platform_get_irq() may return signed unnoticed
Date: Wednesday, April 23, 2008 - 2:49 pm

similarly,
---
dev->irq is unsigned, platform_get_irq() may return signed unnoticed

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
index 194949a..26a735a 100644
--- a/drivers/net/ax88796.c
+++ b/drivers/net/ax88796.c
@@ -838,10 +838,10 @@ static int ax_probe(struct platform_device *pdev)
 
 	/* find the platform resources */
 
-	dev->irq  = platform_get_irq(pdev, 0);
-	if (dev->irq < 0) {
+	ret  = platform_get_irq(pdev, 0);
+	dev->irq = ret;
+	if (ret < 0) {
 		dev_err(&pdev->dev, "no IRQ specified\n");
-		ret = -ENXIO;
 		goto exit_mem;
 	}
 

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] ARM: am79c961a: platform_get_irq() may return sign ..., Roel Kluin, (Wed Apr 23, 2:44 pm)
[PATCH 2/2] ARM: ax88796: platform_get_irq() may return si ..., Roel Kluin, (Wed Apr 23, 2:49 pm)
Re: [PATCH] ARM: am79c961a: platform_get_irq() may return ..., Uwe , (Wed Apr 23, 11:11 pm)
Re: [PATCH 2/2] ARM: ax88796: platform_get_irq() may retur ..., Russell King - ARM Linux, (Mon Apr 28, 1:09 pm)
Re: [PATCH] ARM: am79c961a: platform_get_irq() may return ..., Jeff Garzik, (Mon Apr 28, 10:59 pm)