Home » Mailing list archives » linux-kernel » 2008 » April » 23

[PATCH] ARM: am79c961a: platform_get_irq() may return signed unnoticed

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin
Subject: [PATCH] ARM: am79c961a: platform_get_irq() may return signed unnoticed
Date: Wednesday, April 23, 2008 - 2:44 pm

dev->irq is unsigned, platform_get_irq() may return signed unnoticed

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c
index ba6bd03..a637910 100644
--- a/drivers/net/arm/am79c961a.c
+++ b/drivers/net/arm/am79c961a.c
@@ -693,11 +693,15 @@ static int __init am79c961_probe(struct platform_device *pdev)
 	 * done by the ether bootp loader.
 	 */
 	dev->base_addr = res->start;
-	dev->irq = platform_get_irq(pdev, 0);
+	ret = platform_get_irq(pdev, 0);
 
-	ret = -ENODEV;
-	if (dev->irq < 0)
+	if (ret < 0) {
+		ret = -ENODEV;
 		goto nodev;
+	}
+	dev->irq = ret;
+
+	ret = -ENODEV;
 	if (!request_region(dev->base_addr, 0x18, dev->name))
 		goto nodev;
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] ARM: am79c961a: platform_get_irq() may return sign ..., Roel Kluin, (Wed Apr 23, 2:44 pm)
[PATCH 2/2] ARM: ax88796: platform_get_irq() may return si ..., Roel Kluin, (Wed Apr 23, 2:49 pm)
Re: [PATCH] ARM: am79c961a: platform_get_irq() may return ..., Uwe , (Wed Apr 23, 11:11 pm)
Re: [PATCH 2/2] ARM: ax88796: platform_get_irq() may retur ..., Russell King - ARM Linux, (Mon Apr 28, 1:09 pm)
Re: [PATCH] ARM: am79c961a: platform_get_irq() may return ..., Jeff Garzik, (Mon Apr 28, 10:59 pm)