Home » Mailing list archives » linux-kernel » 2008 » April » 23

[PATCH] asic3: platform_get_irq() may return signed unnoticed

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin <12o3l@...>
To: <pb@...>, <sameo@...>, lkml <linux-kernel@...>
Subject: [PATCH] asic3: platform_get_irq() may return signed unnoticed
Date: Wednesday, April 23, 2008 - 5:32 pm

asic->irq_nr is unsigned. platform_get_irq() may return signed unnoticed

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
index f6f2d96..95f7b0c 100644
--- a/drivers/mfd/asic3.c
+++ b/drivers/mfd/asic3.c
@@ -302,7 +302,7 @@ static int asic3_irq_probe(struct platform_device *pdev)
 	unsigned int irq, irq_base;
 
 	asic->irq_nr = platform_get_irq(pdev, 0);
-	if (asic->irq_nr < 0)
+	if (asic->irq_nr == -ENXIO)
 		return asic->irq_nr;
 
 	/* turn on clock to IRQ controller */
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] asic3: platform_get_irq() may return signed unnoticed, Roel Kluin, (Wed Apr 23, 5:32 pm)
[PATCH v2] asic3: platform_get_irq() may return signed unnot..., Roel Kluin, (Wed Apr 23, 6:38 pm)
Re: [PATCH v2] asic3: platform_get_irq() may return signed u..., Roel Kluin, (Wed Apr 23, 6:58 pm)
Re: [PATCH v2] asic3: platform_get_irq() may return signed u..., Samuel Ortiz, (Wed Apr 23, 7:16 pm)