login
Header Space

 
 

[PATCH 2/2] xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe()

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <dbrownell@...>, <spi-devel-general@...>
Cc: lkml <linux-kernel@...>
Date: Wednesday, April 23, 2008 - 4:55 pm

similarly,
---
xilinx_spi->irq is unsigned, so the test fails

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c
index cf6aef3..613db82 100644
--- a/drivers/spi/xilinx_spi.c
+++ b/drivers/spi/xilinx_spi.c
@@ -353,11 +353,12 @@ static int __init xilinx_spi_probe(struct platform_device *dev)
 		goto put_master;
 	}
 
-	xspi->irq = platform_get_irq(dev, 0);
-	if (xspi->irq < 0) {
-		ret = -ENXIO;
+	ret = platform_get_irq(dev, 0);
+	if (ret < 0)
 		goto unmap_io;
-	}
+
+	xspi->irq = ret;
+	ret = 0;
 
 	master->bus_num = pdata->bus_num;
 	master->num_chipselect = pdata->num_chipselect;

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/2] xilinx_spi: test below 0 on unsigned irq in xili..., Roel Kluin, (Wed Apr 23, 4:55 pm)
speck-geostationary