Home » Mailing list archives » linux-kernel » 2008 » April » 23

[PATCH] aty128fb: test below 0 on unsigned pll->post_divider

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin <12o3l@...>
To: <adaplas@...>, <linux-fbdev-devel@...>, lkml <linux-kernel@...>
Subject: [PATCH] aty128fb: test below 0 on unsigned pll-&gt;post_divider
Date: Wednesday, April 23, 2008 - 2:37 pm

pll->post_divider is unsigned, so the test fails

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/video/aty/aty128fb.c b/drivers/video/aty/aty128fb.c
index cbd3308..5617259 100644
--- a/drivers/video/aty/aty128fb.c
+++ b/drivers/video/aty/aty128fb.c
@@ -1339,8 +1339,6 @@ static int aty128_var_to_pll(u32 period_in_ps, struct aty128_pll *pll,
 	if (vclk * 12 < c.ppll_min)
 		vclk = c.ppll_min/12;
 
-	pll->post_divider = -1;
-
 	/* now, find an acceptable divider */
 	for (i = 0; i < sizeof(post_dividers); i++) {
 		output_freq = post_dividers[i] * vclk;
@@ -1350,7 +1348,7 @@ static int aty128_var_to_pll(u32 period_in_ps, struct aty128_pll *pll,
 		}
 	}
 
-	if (pll->post_divider < 0)
+	if (i == sizeof(post_dividers))
 		return -EINVAL;
 
 	/* calculate feedback divider */
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] aty128fb: test below 0 on unsigned pll->post_divider, Roel Kluin, (Wed Apr 23, 2:37 pm)
[PATCH v2] aty128fb: test below 0 on unsigned pll-&gt;post_d..., Roel Kluin, (Wed Apr 23, 3:24 pm)