Home » Mailing list archives » linux-kernel » 2008 » April » 23

[PATCH] powerpc: mpic_pasemi_msi: failed allocation unnoticed

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin <12o3l@...>
To: <paulus@...>, <linuxppc-dev@...>
Cc: lkml <linux-kernel@...>
Subject: [PATCH] powerpc: mpic_pasemi_msi: failed allocation unnoticed
Date: Wednesday, April 23, 2008 - 12:51 pm

bitmap_find_free_region(), called by mpic_msi_alloc_hwirqs() may
return -ENOMEM, but hwirq of type irq_hw_number_t which is unsigned.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
The functions can be found respectively in:
//---[ vi lib/bitmap.c +807 ]---
//---[ vi arch/powerpc/sysdev/mpic_msi.c +39 ]---

diff --git a/arch/powerpc/sysdev/mpic_pasemi_msi.c b/arch/powerpc/sysdev/mpic_pasemi_msi.c
index 33cbfb2..a15ac5c 100644
--- a/arch/powerpc/sysdev/mpic_pasemi_msi.c
+++ b/arch/powerpc/sysdev/mpic_pasemi_msi.c
@@ -109,7 +109,7 @@ static int pasemi_msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
 		 * sources can be changed independently.
 		 */
 		hwirq = mpic_msi_alloc_hwirqs(msi_mpic, ALLOC_CHUNK);
-		if (hwirq < 0) {
+		if (hwirq == -ENOMEM) {
 			pr_debug("pasemi_msi: failed allocating hwirq\n");
 			return hwirq;
 		}
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] powerpc: mpic_pasemi_msi: failed allocation unnoticed, Roel Kluin, (Wed Apr 23, 12:51 pm)
[PATCH 1/2 v2] powerpc: mpic_pasemi_msi: failed allocation u..., Roel Kluin, (Wed Apr 23, 6:32 pm)
[PATCH 2/2] mpic_u3msi: mpic_u3msi: failed allocation unnoti..., Roel Kluin, (Wed Apr 23, 3:00 pm)
Re: [PATCH 2/2] mpic_u3msi: mpic_u3msi: failed allocation un..., Segher Boessenkool, (Wed Apr 23, 6:09 pm)
[PATCH 2/2 v2] mpic_u3msi: mpic_u3msi: failed allocation unn..., Roel Kluin, (Wed Apr 23, 6:25 pm)
Re: [PATCH 2/2 v2] mpic_u3msi: mpic_u3msi: failed allocation..., Michael Ellerman, (Wed Apr 23, 7:36 pm)
Re: [PATCH 2/2 v2] mpic_u3msi: mpic_u3msi: failed allocation..., Benjamin Herrenschmidt, (Wed Apr 23, 8:42 pm)
Re: [PATCH 2/2 v2] mpic_u3msi: mpic_u3msi: failed allocation..., Roel Kluin, (Wed Apr 23, 7:03 pm)
[PATCH 2/2] powerpc: mpic_pasemi_msi: failed allocation unno..., Roel Kluin, (Wed Apr 23, 12:54 pm)