login
Header Space

 
 

Re: Pull request for semaphore include changes

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Matthew Wilcox <matthew@...>
Cc: Linus Torvalds <torvalds@...>, <linux-kernel@...>, David Howells <dhowells@...>
Date: Wednesday, April 23, 2008 - 11:57 am

>  drivers/infiniband/core/user_mad.c            |    2 +-

Let me say up front I have no problem with this change, which moved from
<asm/semaphore.h> to <linux/semaphore.h>.  So take this email as an
honest question and not any form of complaint or criticism.  But looking
at that user_mad.c file in particular, I don't see any use of anything
that looks like it would come from semaphore.h.

So I'm wondering why you didn't just delete the inclusion, as you did in
other places?  I can merge a follow-up that does that cleanup (which
builds and works fine on my usual architectures) but I want to avoid
breaking avr32 allyesconfig or something like that.

(Commit 2fe7e6f7 "IB/umad: Simplify and fix locking" changed the locking
scheme, so maybe you looked at an older file)

Thanks,
  Roland
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Pull request for semaphore include changes, Matthew Wilcox, (Sat Apr 19, 2:40 pm)
Re: Pull request for semaphore include changes, Roland Dreier, (Wed Apr 23, 11:57 am)
Re: Pull request for semaphore include changes, Matthew Wilcox, (Wed Apr 23, 12:03 pm)
Re: Pull request for semaphore include changes, Roland Dreier, (Wed Apr 23, 12:06 pm)
Re: Pull request for semaphore include changes, Geert Uytterhoeven, (Wed Apr 23, 3:18 am)
Re: Pull request for semaphore include changes, Matthew Wilcox, (Wed Apr 23, 7:13 am)
speck-geostationary