Re: [bisected] Latest git not seeing HD with sata_nv

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Roland Dreier
Date: Tuesday, April 22, 2008 - 6:25 pm

> It seems that commit 305d2a1a ("libata: unify mechanism to request
 > follow-up SRST") causes sata_nv not to see the HD on a system I have
 > here; with current git (80750147), I get this in my bootlog:

I wonder if this is related to the code

static int nv_hardreset(struct ata_link *link, unsigned int *class,
			unsigned long deadline)
{
	unsigned int dummy;

	/* SATA hardreset fails to retrieve proper device signature on
	 * some controllers.  Don't classify on hardreset.  For more
	 * info, see http://bugzilla.kernel.org/show_bug.cgi?id=3352
	 */
	return sata_sff_hardreset(link, &dummy, deadline);
}

It seems especially suspicious given that 305d2a1a touches
sata_sff_hardreset...

 - R.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[bisected] Latest git not seeing HD with sata_nv, Roland Dreier, (Tue Apr 22, 4:20 pm)
Re: [bisected] Latest git not seeing HD with sata_nv, Yinghai Lu, (Tue Apr 22, 4:47 pm)
Re: [bisected] Latest git not seeing HD with sata_nv, Roland Dreier, (Tue Apr 22, 6:25 pm)
Re: [bisected] Latest git not seeing HD with sata_nv, Roland Dreier, (Tue Apr 22, 6:38 pm)