Home » Mailing list archives » linux-kernel » 2008 » April » 22

[PATCH] PCI Express ASPM support should default to 'No'

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jesper Juhl <jesper.juhl@...>
To: Shaohua Li <shaohua.li@...>
Cc: <linux-kernel@...>, Ingo Molnar <mingo@...>, Jesper Juhl <jesper.juhl@...>
Subject: [PATCH] PCI Express ASPM support should default to 'No'
Date: Tuesday, April 22, 2008 - 6:28 pm

Running 'make oldconfig' I just noticed that PCIEASPM defaults to 
'y' in Kconfig even though the feature is both experimental and the 
help text recommends that if you are unsure you say 'n'.
It seems to me that this really should default to 'n', not 'y' at the 
moment.
The following patch makes that change. Please consider applying.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
index 25b04fb..5a0c6ad 100644
--- a/drivers/pci/pcie/Kconfig
+++ b/drivers/pci/pcie/Kconfig
@@ -33,7 +33,7 @@ source "drivers/pci/pcie/aer/Kconfig"
 config PCIEASPM
 	bool "PCI Express ASPM support(Experimental)"
 	depends on PCI && EXPERIMENTAL && PCIEPORTBUS
-	default y
+	default n
 	help
 	  This enables PCI Express ASPM (Active State Power Management) and
 	  Clock Power Management. ASPM supports state L0/L0s/L1.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] PCI Express ASPM support should default to 'No', Jesper Juhl, (Tue Apr 22, 6:28 pm)
Re: [PATCH] PCI Express ASPM support should default to 'No', Jesse Barnes, (Tue Apr 22, 8:12 pm)
Re: [PATCH] PCI Express ASPM support should default to 'No', Shaohua Li, (Tue Apr 22, 9:05 pm)
Re: [PATCH] PCI Express ASPM support should default to 'No', Andi Kleen, (Thu Apr 24, 3:49 am)
Re: [PATCH] PCI Express ASPM support should default to 'No', Jesper Juhl, (Sun Apr 27, 4:01 pm)
Re: [PATCH] PCI Express ASPM support should default to 'No', Shaohua Li, (Thu Apr 24, 4:02 am)
Re: [PATCH] PCI Express ASPM support should default to 'No', Jesse Barnes, (Thu Apr 24, 11:33 am)
Re: [PATCH] PCI Express ASPM support should default to 'No', Shaohua Li, (Thu Apr 24, 9:16 pm)
Re: [PATCH] PCI Express ASPM support should default to 'No', Jesse Barnes, (Wed Apr 23, 6:46 pm)