Re: [PATCH] mfd: kconfig exposing unbuildable driver

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Russell King <rmk+lkml@...>
Cc: Harvey Harrison <harvey.harrison@...>, LKML <linux-kernel@...>, Andrew Morton <akpm@...>, Randy Dunlap <randy.dunlap@...>
Date: Tuesday, April 22, 2008 - 5:05 pm

On Tue, 22 Apr 2008, Russell King wrote:

Hmm. While I in general support the notion of trying to compile drivers on 
as wide a variety as hardware as possible, if that HTC_PASIC3 thing really 
is a PXA-only piece of hardware, I don't really see the point of not 
making the config file accurately represent that.

That said, as far as I can tell, the compile failure is because of this 
line:

	#include <asm/arch/pxa-regs.h>

and I cannot for the life of me see _why_ it tries to include that header 
file. It seems to compile fine on x96-64 if you just remove that include, 
and while I still think it should depend on ARCH_PXA just because it makes 
no sense _not_ to, I do wonder why that include is there in the first 
place.

Hmm?

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] mfd: kconfig exposing unbuildable driver, Harvey Harrison, (Tue Apr 22, 4:25 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, Russell King, (Tue Apr 22, 4:33 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, pHilipp Zabel, (Wed Apr 23, 4:02 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, Linus Torvalds, (Tue Apr 22, 5:05 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, pHilipp Zabel, (Wed Apr 23, 4:14 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, Russell King, (Tue Apr 22, 5:36 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, Linus Torvalds, (Tue Apr 22, 5:47 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, Randy.Dunlap, (Tue Apr 22, 4:38 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, Russell King, (Tue Apr 22, 4:45 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, Randy.Dunlap, (Tue Apr 22, 4:47 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, Russell King, (Tue Apr 22, 5:01 pm)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, Andrew Morton, (Wed Apr 23, 2:02 am)
Re: [PATCH] mfd: kconfig exposing unbuildable driver, Randy Dunlap, (Tue Apr 22, 5:06 pm)