Home » Mailing list archives » linux-kernel » 2008 » April » 22

Re: [PATCH 1/11] Add generic helpers for arch IPI function calls

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jens Axboe <jens.axboe@...>
To: Linus Torvalds <torvalds@...>
Cc: <linux-arch@...>, <linux-kernel@...>, <npiggin@...>
Subject: Re: [PATCH 1/11] Add generic helpers for arch IPI function calls
Date: Tuesday, April 22, 2008 - 11:07 am

On Tue, Apr 22 2008, Linus Torvalds wrote:

Yes, if wait is set, it's on the stack.


Hmm yes, double checking it and it would seem to leak for wait &&
kmalloc'ed data. I think I originally had the wait case as always on
stack, which would explain this leak.


Alright, I'll make 'wait' always alloc on the stack and I'll make
allocation failure turn into 'wait' as well. That'll leave just
kmalloc() and stack allocation, killing the static data fallback.


No, I think that should work ok. I'll post a new series with the changes
so we can see if we agree.

-- 
Jens Axboe

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/11] Generic smp_call_function() and friends, Jens Axboe, (Tue Apr 22, 3:57 am)
Re: [PATCH 0/11] Generic smp_call_function() and friends, Peter Zijlstra, (Tue Apr 22, 4:48 am)
[PATCH 11/11] s390: convert to generic helpers for IPI funct..., Jens Axboe, (Tue Apr 22, 3:57 am)
[PATCH 11/11] s390: convert to generic helpers for IPI funct..., Jens Axboe, (Tue Apr 22, 3:57 am)
Re: [PATCH 11/11] s390: convert to generic helpers for IPI f..., Martin Schwidefsky, (Tue Apr 22, 4:04 am)
Re: [PATCH 11/11] s390: convert to generic helpers for IPI ..., Jens Axboe, (Tue Apr 22, 4:07 am)
[PATCH 9/11] parisc: convert to generic helpers for IPI func..., Jens Axboe, (Tue Apr 22, 3:57 am)
Re: [PATCH 9/11] parisc: convert to generic helpers for IPI ..., Kyle McMartin, (Tue Apr 22, 10:09 am)
Re: [PATCH 9/11] parisc: convert to generic helpers for IPI ..., Jens Axboe, (Tue Apr 22, 10:27 am)
Re: [PATCH 9/11] parisc: convert to generic helpers for IPI ..., Kyle McMartin, (Tue Apr 22, 10:30 am)
Re: [PATCH 9/11] parisc: convert to generic helpers for IPI ..., Jens Axboe, (Tue Apr 22, 10:49 am)
[PATCH 10/11] sh: convert to generic helpers for IPI functio..., Jens Axboe, (Tue Apr 22, 3:57 am)
[PATCH 8/11] mips: convert to generic helpers for IPI functi..., Jens Axboe, (Tue Apr 22, 3:57 am)
[PATCH 6/11] arm: convert to generic helpers for IPI functio..., Jens Axboe, (Tue Apr 22, 3:57 am)
Re: [PATCH 6/11] arm: convert to generic helpers for IPI fun..., Catalin Marinas, (Tue Apr 22, 11:00 am)
Re: [PATCH 6/11] arm: convert to generic helpers for IPI fun..., Jens Axboe, (Tue Apr 22, 2:43 pm)
[PATCH 7/11] m32r: convert to generic helpers for IPI functi..., Jens Axboe, (Tue Apr 22, 3:57 am)
[PATCH 5/11] alpha: convert to generic helpers for IPI funct..., Jens Axboe, (Tue Apr 22, 3:57 am)
[PATCH 2/11] x86: convert to generic helpers for IPI functio..., Jens Axboe, (Tue Apr 22, 3:57 am)
Re: [PATCH 2/11] x86: convert to generic helpers for IPI fun..., Ingo Molnar, (Tue Apr 22, 4:47 am)
Re: [PATCH 2/11] x86: convert to generic helpers for IPI fun..., Jeremy Fitzhardinge, (Sat Apr 26, 4:59 am)
Re: [PATCH 2/11] x86: convert to generic helpers for IPI fun..., Jacek Luczak, (Tue Apr 22, 4:48 am)
Re: [PATCH 2/11] x86: convert to generic helpers for IPI fun..., Jens Axboe, (Tue Apr 22, 4:56 am)
Re: [PATCH 2/11] x86: convert to generic helpers for IPI fun..., Jacek Luczak, (Tue Apr 22, 5:04 am)
Re: [PATCH 2/11] x86: convert to generic helpers for IPI fun..., Jens Axboe, (Tue Apr 22, 4:52 am)
Re: [PATCH 2/11] x86: convert to generic helpers for IPI fun..., Sam Ravnborg, (Tue Apr 22, 4:38 am)
Re: [PATCH 2/11] x86: convert to generic helpers for IPI fun..., Jens Axboe, (Tue Apr 22, 4:43 am)
Re: [PATCH 2/11] x86: convert to generic helpers for IPI fun..., Jens Axboe, (Tue Apr 22, 7:15 am)
[PATCH 4/11] ia64: convert to generic helpers for IPI functi..., Jens Axboe, (Tue Apr 22, 3:57 am)
[PATCH 3/11] powerpc: convert to generic helpers for IPI fun..., Jens Axboe, (Tue Apr 22, 3:57 am)
Re: [PATCH 3/11] powerpc: convert to generic helpers for IPI..., Paul Mackerras, (Tue Apr 22, 8:03 am)
Re: [PATCH 3/11] powerpc: convert to generic helpers for IPI..., Jens Axboe, (Tue Apr 22, 8:13 am)
Re: [PATCH 3/11] powerpc: convert to generic helpers for IPI..., Paul Mackerras, (Tue Apr 22, 8:42 am)
Re: [PATCH 3/11] powerpc: convert to generic helpers for IPI..., Jens Axboe, (Tue Apr 22, 2:51 pm)
[PATCH 1/11] Add generic helpers for arch IPI function calls, Jens Axboe, (Tue Apr 22, 3:57 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Mark Lord, (Tue Apr 22, 7:12 pm)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Wed Apr 23, 3:24 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Mark Lord, (Wed Apr 23, 9:42 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Wed Apr 23, 9:51 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Mark Lord, (Wed Apr 23, 10:46 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Thu Apr 24, 6:59 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Pavel Machek, (Sat Apr 26, 4:04 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Mark Lord, (Mon Apr 28, 11:13 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Pavel Machek, (Thu May 1, 12:23 pm)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Mark Lord, (Thu Apr 24, 8:44 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Pavel Machek, (Fri Apr 25, 7:08 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Rafael J. Wysocki, (Thu Apr 24, 5:30 pm)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Linus Torvalds, (Tue Apr 22, 10:43 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Linus Torvalds, (Tue Apr 22, 10:58 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Tue Apr 22, 11:07 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Tue Apr 22, 10:51 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Linus Torvalds, (Tue Apr 22, 11:01 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Tue Apr 22, 12:49 pm)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Tue Apr 22, 1:04 pm)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Tue Apr 22, 1:13 pm)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Linus Torvalds, (Tue Apr 22, 1:29 pm)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Tue Apr 22, 2:23 pm)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Linus Torvalds, (Tue Apr 22, 2:39 pm)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Avi Kivity, (Tue Apr 22, 5:16 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Tue Apr 22, 5:22 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Tue Apr 22, 7:14 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Peter Zijlstra, (Tue Apr 22, 9:00 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Tue Apr 22, 10:25 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Avi Kivity, (Tue Apr 22, 10:38 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Jens Axboe, (Tue Apr 22, 10:53 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Peter Zijlstra, (Tue Apr 22, 10:43 am)
Re: [PATCH 1/11] Add generic helpers for arch IPI function c..., Avi Kivity, (Tue Apr 22, 10:47 am)